Re: [PATCH v3 1/1] can: dev: add software tx timestamps

2021-01-12 Thread Vincent MAILHOL
On Tue. 12 Jan 2021 at 16:58, Marc Kleine-Budde wrote: > > On 1/12/21 1:00 AM, Vincent MAILHOL wrote: > [...] > > > Mark: do you want me to send a v4 of that patch with above > > comment removed or can you directly do the change in your testing > > branch? > > Please send a patch on-top of linux-c

Re: [PATCH v3 1/1] can: dev: add software tx timestamps

2021-01-12 Thread Marc Kleine-Budde
On 1/12/21 1:00 AM, Vincent MAILHOL wrote: [...] > Mark: do you want me to send a v4 of that patch with above > comment removed or can you directly do the change in your testing > branch? Please send a patch on-top of linux-can-next/testing Marc -- Pengutronix e.K. | Marc Klein

Re: [PATCH v3 1/1] can: dev: add software tx timestamps

2021-01-11 Thread Vincent MAILHOL
On Tue. 12 Jan 2021 at 11:14, Richard Cochran wrote: > > On Tue, Jan 12, 2021 at 09:00:33AM +0900, Vincent MAILHOL wrote: > > Out of curiosity, which programs do you use? I guess wireshark > > but please let me know if you use any other programs (I just use > > to write a small C program to do the

Re: [PATCH v3 1/1] can: dev: add software tx timestamps

2021-01-11 Thread Richard Cochran
On Tue, Jan 12, 2021 at 09:00:33AM +0900, Vincent MAILHOL wrote: > Out of curiosity, which programs do you use? I guess wireshark > but please let me know if you use any other programs (I just use > to write a small C program to do the stuff). I was thinking of PTP over DeviceNET (which, in turn,

Re: [PATCH v3 1/1] can: dev: add software tx timestamps

2021-01-11 Thread Vincent MAILHOL
On Tue. 12 Jan 2021 at 02:11, Richard Cochran wrote: > > On Sun, Jan 10, 2021 at 09:49:03PM +0900, Vincent Mailhol wrote: > > * The hardware rx timestamp of a local loopback message is the > > hardware tx timestamp. This means that there are no needs to > > implement SOF_TIMESTAMPING_TX_

Re: [PATCH v3 1/1] can: dev: add software tx timestamps

2021-01-11 Thread Richard Cochran
On Sun, Jan 10, 2021 at 09:49:03PM +0900, Vincent Mailhol wrote: > * The hardware rx timestamp of a local loopback message is the > hardware tx timestamp. This means that there are no needs to > implement SOF_TIMESTAMPING_TX_HARDWARE for CAN sockets. I can't agree with that statement. T

Re: [PATCH v3 1/1] can: dev: add software tx timestamps

2021-01-11 Thread Marc Kleine-Budde
On 1/10/21 1:49 PM, Vincent Mailhol wrote: > Call skb_tx_timestamp() within can_put_echo_skb() so that a software > tx timestamp gets attached on the skb. > > There two main reasons to include this call in can_put_echo_skb(): > > * It easily allow to enable the tx timestamp on all devices with

[PATCH v3 1/1] can: dev: add software tx timestamps

2021-01-10 Thread Vincent Mailhol
Call skb_tx_timestamp() within can_put_echo_skb() so that a software tx timestamp gets attached on the skb. There two main reasons to include this call in can_put_echo_skb(): * It easily allow to enable the tx timestamp on all devices with just one small change. * According to Documentat