Re: [PATCH v3 1/1] fpga: dfl: afu: harden port enable logic

2021-02-04 Thread Russ Weight
On 2/3/21 5:38 PM, Wu, Hao wrote: >> On 2/3/21 1:01 AM, Wu, Hao wrote: >>>> Subject: [PATCH v3 1/1] fpga: dfl: afu: harden port enable logic >>>> >>>> Port enable is not complete until ACK = 0. Change >>>> __afu_port_enable() to guarantee t

Re: [PATCH v3 1/1] fpga: dfl: afu: harden port enable logic

2021-02-04 Thread Tom Rix
On 2/3/21 3:06 PM, Russ Weight wrote: > > On 2/3/21 7:25 AM, Tom Rix wrote: >> ..snip.. >> >> On 2/2/21 3:06 PM, Russ Weight wrote: >>> diff --git a/drivers/fpga/dfl-afu.h b/drivers/fpga/dfl-afu.h >>> index 576e94960086..e5020e2b1f3d 100644 >>> --- a/drivers/fpga/dfl-afu.h >>> +++ b/drivers/fpga/

RE: [PATCH v3 1/1] fpga: dfl: afu: harden port enable logic

2021-02-03 Thread Wu, Hao
> On 2/3/21 1:01 AM, Wu, Hao wrote: > >> Subject: [PATCH v3 1/1] fpga: dfl: afu: harden port enable logic > >> > >> Port enable is not complete until ACK = 0. Change > >> __afu_port_enable() to guarantee that the enable process > >> is complete

Re: [PATCH v3 1/1] fpga: dfl: afu: harden port enable logic

2021-02-03 Thread Russ Weight
On 2/3/21 7:25 AM, Tom Rix wrote: > ..snip.. > > On 2/2/21 3:06 PM, Russ Weight wrote: >> diff --git a/drivers/fpga/dfl-afu.h b/drivers/fpga/dfl-afu.h >> index 576e94960086..e5020e2b1f3d 100644 >> --- a/drivers/fpga/dfl-afu.h >> +++ b/drivers/fpga/dfl-afu.h >> @@ -80,7 +80,7 @@ struct dfl_afu {

Re: [PATCH v3 1/1] fpga: dfl: afu: harden port enable logic

2021-02-03 Thread Russ Weight
On 2/3/21 1:01 AM, Wu, Hao wrote: >> Subject: [PATCH v3 1/1] fpga: dfl: afu: harden port enable logic >> >> Port enable is not complete until ACK = 0. Change >> __afu_port_enable() to guarantee that the enable process >> is complete by polling for ACK == 0. &g

Re: [PATCH v3 1/1] fpga: dfl: afu: harden port enable logic

2021-02-03 Thread Tom Rix
..snip.. On 2/2/21 3:06 PM, Russ Weight wrote: > diff --git a/drivers/fpga/dfl-afu.h b/drivers/fpga/dfl-afu.h > index 576e94960086..e5020e2b1f3d 100644 > --- a/drivers/fpga/dfl-afu.h > +++ b/drivers/fpga/dfl-afu.h > @@ -80,7 +80,7 @@ struct dfl_afu { > }; > > /* hold pdata->lock when call __af

RE: [PATCH v3 1/1] fpga: dfl: afu: harden port enable logic

2021-02-03 Thread Wu, Hao
> Subject: [PATCH v3 1/1] fpga: dfl: afu: harden port enable logic > > Port enable is not complete until ACK = 0. Change > __afu_port_enable() to guarantee that the enable process > is complete by polling for ACK == 0. > > Signed-off-by: Russ Weight > --- > v

[PATCH v3 1/1] fpga: dfl: afu: harden port enable logic

2021-02-02 Thread Russ Weight
Port enable is not complete until ACK = 0. Change __afu_port_enable() to guarantee that the enable process is complete by polling for ACK == 0. Signed-off-by: Russ Weight --- v3: - afu_port_err_clear() changed to prioritize port_enable failure over other a detected mismatch in port errors.