Re: [PATCH v3 1/1] pinctrl: baytrail: Warn if direct IRQ GPIO set to output

2014-06-12 Thread Linus Walleij
On Wed, Jun 4, 2014 at 12:25 AM, wrote: > From: Eric Ernst > > For Baytrail, you should never set a GPIO set to direct_irq > to output mode. When direct_irq_en is set for a GPIO, it is > tied directly to an APIC internally, and making the pad output > does not make any sense. Assert a WARN()

Re: [PATCH v3 1/1] pinctrl: baytrail: Warn if direct IRQ GPIO set to output

2014-06-12 Thread Linus Walleij
On Wed, Jun 4, 2014 at 12:25 AM, eric.er...@linux.intel.com wrote: From: Eric Ernst eric.er...@linux.intel.com For Baytrail, you should never set a GPIO set to direct_irq to output mode. When direct_irq_en is set for a GPIO, it is tied directly to an APIC internally, and making the pad

Re: [PATCH v3 1/1] pinctrl: baytrail: Warn if direct IRQ GPIO set to output

2014-06-04 Thread Mika Westerberg
On Tue, Jun 03, 2014 at 03:25:16PM -0700, eric.er...@linux.intel.com wrote: > From: Eric Ernst > > For Baytrail, you should never set a GPIO set to direct_irq > to output mode. When direct_irq_en is set for a GPIO, it is > tied directly to an APIC internally, and making the pad output > does

Re: [PATCH v3 1/1] pinctrl: baytrail: Warn if direct IRQ GPIO set to output

2014-06-04 Thread Mika Westerberg
On Tue, Jun 03, 2014 at 03:25:16PM -0700, eric.er...@linux.intel.com wrote: From: Eric Ernst eric.er...@linux.intel.com For Baytrail, you should never set a GPIO set to direct_irq to output mode. When direct_irq_en is set for a GPIO, it is tied directly to an APIC internally, and making the

[PATCH v3 1/1] pinctrl: baytrail: Warn if direct IRQ GPIO set to output

2014-06-03 Thread eric . ernst
From: Eric Ernst For Baytrail, you should never set a GPIO set to direct_irq to output mode. When direct_irq_en is set for a GPIO, it is tied directly to an APIC internally, and making the pad output does not make any sense. Assert a WARN() in the event this happens. Signed-off-by: Eric Ernst

[PATCH v3 1/1] pinctrl: baytrail: Warn if direct IRQ GPIO set to output

2014-06-03 Thread eric . ernst
From: Eric Ernst eric.er...@linux.intel.com For Baytrail, you should never set a GPIO set to direct_irq to output mode. When direct_irq_en is set for a GPIO, it is tied directly to an APIC internally, and making the pad output does not make any sense. Assert a WARN() in the event this happens.