Re: [PATCH v3 1/1] s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks

2021-03-09 Thread Tony Krowiak
On 3/9/21 5:23 AM, Halil Pasic wrote: On Thu, 4 Mar 2021 12:43:44 -0500 Tony Krowiak wrote: On the other hand, if we don't have ->kvm because something broke, then we may be out of luck anyway. There will certainly be no way to unregister the GISC; however, it may still be possible to

Re: [PATCH v3 1/1] s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks

2021-03-09 Thread Halil Pasic
On Thu, 4 Mar 2021 12:43:44 -0500 Tony Krowiak wrote: > On the other hand, if we don't have ->kvm because something broke, > then we may be out of luck anyway. There will certainly be no > way to unregister the GISC; however, it may still be possible > to unpin the pages if we still have

Re: [PATCH v3 1/1] s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks

2021-03-04 Thread Tony Krowiak
On 3/3/21 2:47 PM, Halil Pasic wrote: On Wed, 3 Mar 2021 12:10:11 -0500 Tony Krowiak wrote: On 3/3/21 10:23 AM, Halil Pasic wrote: On Tue, 2 Mar 2021 15:43:22 -0500 Tony Krowiak wrote: This patch fixes a lockdep splat introduced by commit f21916ec4826 ("s390/vfio-ap: clean up

Re: [PATCH v3 1/1] s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks

2021-03-04 Thread Tony Krowiak
On 3/3/21 2:42 PM, Halil Pasic wrote: On Wed, 3 Mar 2021 11:41:22 -0500 Tony Krowiak wrote: How do you exect userspace to react to this -ENODEV? The VFIO_DEVICE_RESET ioctl expects a return code. The vfio_ap_mdev_reset_queues() function can return -EIO or -EBUSY, so I would expect

Re: [PATCH v3 1/1] s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks

2021-03-03 Thread Halil Pasic
On Wed, 3 Mar 2021 11:41:22 -0500 Tony Krowiak wrote: > > How do you exect userspace to react to this -ENODEV? > > The VFIO_DEVICE_RESET ioctl expects a return code. > The vfio_ap_mdev_reset_queues() function can return -EIO or > -EBUSY, so I would expect userspace to handle -ENODEV >

Re: [PATCH v3 1/1] s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks

2021-03-03 Thread Halil Pasic
On Wed, 3 Mar 2021 12:10:11 -0500 Tony Krowiak wrote: > On 3/3/21 10:23 AM, Halil Pasic wrote: > > On Tue, 2 Mar 2021 15:43:22 -0500 > > Tony Krowiak wrote: > > > >> This patch fixes a lockdep splat introduced by commit f21916ec4826 > >> ("s390/vfio-ap: clean up vfio_ap resources when KVM

Re: [PATCH v3 1/1] s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks

2021-03-03 Thread Tony Krowiak
On 3/3/21 10:23 AM, Halil Pasic wrote: On Tue, 2 Mar 2021 15:43:22 -0500 Tony Krowiak wrote: This patch fixes a lockdep splat introduced by commit f21916ec4826 ("s390/vfio-ap: clean up vfio_ap resources when KVM pointer invalidated"). The lockdep splat only occurs when starting a Secure

Re: [PATCH v3 1/1] s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks

2021-03-03 Thread Tony Krowiak
On 3/3/21 10:23 AM, Halil Pasic wrote: On Tue, 2 Mar 2021 15:43:22 -0500 Tony Krowiak wrote: This patch fixes a lockdep splat introduced by commit f21916ec4826 ("s390/vfio-ap: clean up vfio_ap resources when KVM pointer invalidated"). The lockdep splat only occurs when starting a Secure

Re: [PATCH v3 1/1] s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks

2021-03-03 Thread Halil Pasic
On Tue, 2 Mar 2021 15:43:22 -0500 Tony Krowiak wrote: > This patch fixes a lockdep splat introduced by commit f21916ec4826 > ("s390/vfio-ap: clean up vfio_ap resources when KVM pointer invalidated"). > The lockdep splat only occurs when starting a Secure Execution guest. > Crypto virtualization

[PATCH v3 1/1] s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks

2021-03-02 Thread Tony Krowiak
This patch fixes a lockdep splat introduced by commit f21916ec4826 ("s390/vfio-ap: clean up vfio_ap resources when KVM pointer invalidated"). The lockdep splat only occurs when starting a Secure Execution guest. Crypto virtualization (vfio_ap) is not yet supported for SE guests; however, in order