Re: [alsa-devel] [PATCH v3 1/2] ALSA: pcm: add SNDRV_PCM_FORMAT_{S, U}20

2017-11-27 Thread Maciej S. Szmigiero
On 27.11.2017 21:28, Takashi Iwai wrote: > On Mon, 27 Nov 2017 00:09:47 +0100, > Maciej S. Szmigiero wrote: >> diff --git a/include/sound/soc-dai.h b/include/sound/soc-dai.h >> index 58acd00cae19..d970879944fc 100644 >> --- a/include/sound/soc-dai.h >> +++ b/include/sound/soc-dai.h >> @@ -102,6 +10

Re: [alsa-devel] [PATCH v3 1/2] ALSA: pcm: add SNDRV_PCM_FORMAT_{S, U}20

2017-11-27 Thread Takashi Iwai
On Mon, 27 Nov 2017 00:09:47 +0100, Maciej S. Szmigiero wrote: > diff --git a/include/sound/soc-dai.h b/include/sound/soc-dai.h > index 58acd00cae19..d970879944fc 100644 > --- a/include/sound/soc-dai.h > +++ b/include/sound/soc-dai.h > @@ -102,6 +102,8 @@ struct snd_compr_stream; >

Re: [PATCH v3 1/2] ALSA: pcm: add SNDRV_PCM_FORMAT_{S, U}20

2017-11-27 Thread Maciej S. Szmigiero
On 27.11.2017 18:40, Takashi Sakamoto wrote: (..) > > Looks good to me. > > Reviewed-by: Takashi Sakamoto Thanks. > In next time to post any of your v2 patchset, it's better to add commenters > of v1 patchset to CC list, so that your patch reaches the person who has > practical interests in

Re: [PATCH v3 1/2] ALSA: pcm: add SNDRV_PCM_FORMAT_{S, U}20

2017-11-27 Thread Takashi Sakamoto
On Nov 27 2017 08:09, Maciej S. Szmigiero wrote: This format is similar to existing SNDRV_PCM_FORMAT_{S,U}20_3 that keep 20-bit PCM samples in 3 bytes, however i.MX6 platform SSI FIFO does not allow 3-byte accesses (including DMA) so a 4-byte (more conventional) format is needed for it. Signed-o

[PATCH v3 1/2] ALSA: pcm: add SNDRV_PCM_FORMAT_{S,U}20

2017-11-26 Thread Maciej S. Szmigiero
This format is similar to existing SNDRV_PCM_FORMAT_{S,U}20_3 that keep 20-bit PCM samples in 3 bytes, however i.MX6 platform SSI FIFO does not allow 3-byte accesses (including DMA) so a 4-byte (more conventional) format is needed for it. Signed-off-by: Maciej S. Szmigiero --- Changes from v1: Dr