Re: [PATCH v3 1/2] ASoC: codecs: Add support for PCM1789

2018-03-18 Thread Mark Brown
On Sat, Mar 17, 2018 at 07:19:51PM +0800, kbuild test robot wrote: > >> sound/soc/codecs/pcm1789.c:265:1-3: ERROR: test of a variable/field address > > 265if (>work) >266flush_work(>work); This is a legit warning but otherwise this looks good so I'll

Re: [PATCH v3 1/2] ASoC: codecs: Add support for PCM1789

2018-03-18 Thread Mark Brown
On Sat, Mar 17, 2018 at 07:19:51PM +0800, kbuild test robot wrote: > >> sound/soc/codecs/pcm1789.c:265:1-3: ERROR: test of a variable/field address > > 265if (>work) >266flush_work(>work); This is a legit warning but otherwise this looks good so I'll

Re: [PATCH v3 1/2] ASoC: codecs: Add support for PCM1789

2018-03-17 Thread kbuild test robot
Hi Mylène, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on v4.16-rc4] [also build test WARNING on next-20180316] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v3 1/2] ASoC: codecs: Add support for PCM1789

2018-03-17 Thread kbuild test robot
Hi Mylène, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on v4.16-rc4] [also build test WARNING on next-20180316] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH v3 1/2] ASoC: codecs: Add support for PCM1789

2018-03-15 Thread Mylène Josserand
Add Texas Instruments's PCM1789 DAC support. It is a simple DAC and does not have many registers. One particularity about this DAC is that the clocks must be always enabled. Also, an entire software reset is necessary while starting to play a sound otherwise, the clocks are not synchronized (so

[PATCH v3 1/2] ASoC: codecs: Add support for PCM1789

2018-03-15 Thread Mylène Josserand
Add Texas Instruments's PCM1789 DAC support. It is a simple DAC and does not have many registers. One particularity about this DAC is that the clocks must be always enabled. Also, an entire software reset is necessary while starting to play a sound otherwise, the clocks are not synchronized (so