On 07/06/2016 06:51 AM, Andi Shyti wrote:
>
> I don't see anything wrong on the above. We could make it as:
> @@ -640,13 +639,7 @@ static void s3c64xx_spi_config(struct
> s3c64xx_spi_driver_data *sdd)
>
> writel(val, regs + S3C64XX_SPI_MODE_CFG);
>
> - if (sdd->port_conf->clk_f
Hi Sylwester,
> +#if 0
> clocks = <&cmu_peric CLK_PCLK_SPI1>,
> <&cmu_top CLK_SCLK_SPI1_PERIC>;
> +#else
> + clocks = <&cmu_peric CLK_PCLK_SPI1>,
> +<&cmu_peric CLK_SCLK_SPI1>;
> +#endif
On 07/04/2016 12:26 PM, Andi Shyti wrote:
> The single clock lines are not configured in the exynos5433 dts,
> but in the drivers/clk/samsung/clk-exynos5433.c file and it's the
> only place where we can set the flags.
I meant we could amend which clocks are specified at the SPI bus device
DT nod
Hi Sylwester,
> > GATE(CLK_SCLK_SPI1, "sclk_spi1", "sclk_spi1_peric", ENABLE_SCLK_PERIC,
> > - 4, CLK_IGNORE_UNUSED | CLK_SET_RATE_PARENT, 0),
> > + 4, CLK_IS_CRITICAL | CLK_SET_RATE_PARENT, 0),
>
> As Tomasz pointed out, this should be addressed in the dri
On 06/30/2016 09:15 AM, Andi Shyti wrote:
> The CLK_IGNORE_UNUSED flag has to be avoided whenever possible.
In general I would rather disagree.
> Use the CLK_IS_CRITICAL flag instead for critical SPI1 clocks,
> which enables the clock line during boot time.
>
> Suggested-by: Tomasz Figa
> Signe
The CLK_IGNORE_UNUSED flag has to be avoided whenever possible.
Use the CLK_IS_CRITICAL flag instead for critical SPI1 clocks,
which enables the clock line during boot time.
Suggested-by: Tomasz Figa
Signed-off-by: Andi Shyti
---
drivers/clk/samsung/clk-exynos5433.c | 4 ++--
1 file changed, 2
6 matches
Mail list logo
