Re: [PATCH v3 1/2] drm/dsi: Implement dcs set/get display brightness

2016-07-19 Thread Sean Paul
On Tue, Jul 19, 2016 at 5:42 AM, Vinay Simha wrote: > just to be inline with the existing code (funcs: > mipi_dsi_dcs_get_power_mode, mipi_dsi_dcs_get_pixel_format) in > drivers/gpu/drm/drm_mipi_dsi.c followed the same for > mipi_dsi_dcs_get_display_brightness > > We may need

Re: [PATCH v3 1/2] drm/dsi: Implement dcs set/get display brightness

2016-07-19 Thread Sean Paul
On Tue, Jul 19, 2016 at 5:42 AM, Vinay Simha wrote: > just to be inline with the existing code (funcs: > mipi_dsi_dcs_get_power_mode, mipi_dsi_dcs_get_pixel_format) in > drivers/gpu/drm/drm_mipi_dsi.c followed the same for > mipi_dsi_dcs_get_display_brightness > > We may need to change as you

Re: [PATCH v3 1/2] drm/dsi: Implement dcs set/get display brightness

2016-07-19 Thread Vinay Simha
just to be inline with the existing code (funcs: mipi_dsi_dcs_get_power_mode, mipi_dsi_dcs_get_pixel_format) in drivers/gpu/drm/drm_mipi_dsi.c followed the same for mipi_dsi_dcs_get_display_brightness We may need to change as you suggested for other two functions also. please suggest. On Tue,

Re: [PATCH v3 1/2] drm/dsi: Implement dcs set/get display brightness

2016-07-19 Thread Vinay Simha
just to be inline with the existing code (funcs: mipi_dsi_dcs_get_power_mode, mipi_dsi_dcs_get_pixel_format) in drivers/gpu/drm/drm_mipi_dsi.c followed the same for mipi_dsi_dcs_get_display_brightness We may need to change as you suggested for other two functions also. please suggest. On Tue,

Re: [PATCH v3 1/2] drm/dsi: Implement dcs set/get display brightness

2016-07-19 Thread Sean Paul
On Mon, Jul 18, 2016 at 4:28 AM, Vinay Simha BN wrote: > Provide a small convenience wrapper that set/get the > display brightness value > > Cc: John Stultz > Cc: Sumit Semwal > Cc: Archit Taneja >

Re: [PATCH v3 1/2] drm/dsi: Implement dcs set/get display brightness

2016-07-19 Thread Sean Paul
On Mon, Jul 18, 2016 at 4:28 AM, Vinay Simha BN wrote: > Provide a small convenience wrapper that set/get the > display brightness value > > Cc: John Stultz > Cc: Sumit Semwal > Cc: Archit Taneja > Cc: Rob Clark > Cc: Jani Nikula > Cc: Thierry Reding > Cc: Emil Velikov > Signed-off-by:

Re: [PATCH v3 1/2] drm/dsi: Implement dcs set/get display brightness

2016-07-18 Thread Emil Velikov
On 18 July 2016 at 09:28, Vinay Simha BN wrote: > Provide a small convenience wrapper that set/get the > display brightness value > > Cc: John Stultz > Cc: Sumit Semwal > Cc: Archit Taneja > Cc: Rob

Re: [PATCH v3 1/2] drm/dsi: Implement dcs set/get display brightness

2016-07-18 Thread Emil Velikov
On 18 July 2016 at 09:28, Vinay Simha BN wrote: > Provide a small convenience wrapper that set/get the > display brightness value > > Cc: John Stultz > Cc: Sumit Semwal > Cc: Archit Taneja > Cc: Rob Clark > Cc: Jani Nikula > Cc: Thierry Reding > Cc: Emil Velikov > Signed-off-by: Vinay

[PATCH v3 1/2] drm/dsi: Implement dcs set/get display brightness

2016-07-18 Thread Vinay Simha BN
Provide a small convenience wrapper that set/get the display brightness value Cc: John Stultz Cc: Sumit Semwal Cc: Archit Taneja Cc: Rob Clark Cc: Jani Nikula Cc:

[PATCH v3 1/2] drm/dsi: Implement dcs set/get display brightness

2016-07-18 Thread Vinay Simha BN
Provide a small convenience wrapper that set/get the display brightness value Cc: John Stultz Cc: Sumit Semwal Cc: Archit Taneja Cc: Rob Clark Cc: Jani Nikula Cc: Thierry Reding Cc: Emil Velikov Signed-off-by: Vinay Simha BN --- v1: *tested in nexus7 2nd gen. v2: * implemented jani