Re: [PATCH v3 1/2] i2c: Add driver for Cadence I2C controller

2014-04-03 Thread Sören Brinkmann
On Thu, 2014-04-03 at 09:25AM +0200, Michal Simek wrote: > On 04/03/2014 09:10 AM, Wolfram Sang wrote: > > > > Please don't quote large parts of the message f you are not referring to > > it. > > Normally I do it. Forgot sorry. > > >>> +#ifdef CONFIG_PM_SLEEP > >>> +/** > >>> + *

Re: [PATCH v3 1/2] i2c: Add driver for Cadence I2C controller

2014-04-03 Thread Michal Simek
On 04/03/2014 09:10 AM, Wolfram Sang wrote: > > Please don't quote large parts of the message f you are not referring to > it. Normally I do it. Forgot sorry. >>> +#ifdef CONFIG_PM_SLEEP >>> +/** >>> + * cdns_i2c_suspend - Suspend method for the driver >>> + * @_dev: Address of the

Re: [PATCH v3 1/2] i2c: Add driver for Cadence I2C controller

2014-04-03 Thread Wolfram Sang
Please don't quote large parts of the message f you are not referring to it. > > +#ifdef CONFIG_PM_SLEEP > > +/** > > + * cdns_i2c_suspend - Suspend method for the driver > > + * @_dev: Address of the platform_device structure > > + * Return: 0 always > > + * > > + * Put the driver into low

Re: [PATCH v3 1/2] i2c: Add driver for Cadence I2C controller

2014-04-03 Thread Michal Simek
Hi Soren, On 03/11/2014 05:50 PM, Soren Brinkmann wrote: > Add a driver for the Cadence I2C controller. This controller is for > example found in Xilinx Zynq. > > Signed-off-by: Soren Brinkmann > --- > v3: > - incorporate signal handling changes from Mike Looijmans >

Re: [PATCH v3 1/2] i2c: Add driver for Cadence I2C controller

2014-04-03 Thread Sören Brinkmann
On Thu, 2014-04-03 at 09:25AM +0200, Michal Simek wrote: On 04/03/2014 09:10 AM, Wolfram Sang wrote: Please don't quote large parts of the message f you are not referring to it. Normally I do it. Forgot sorry. +#ifdef CONFIG_PM_SLEEP +/** + * cdns_i2c_suspend - Suspend method

Re: [PATCH v3 1/2] i2c: Add driver for Cadence I2C controller

2014-04-03 Thread Michal Simek
Hi Soren, On 03/11/2014 05:50 PM, Soren Brinkmann wrote: Add a driver for the Cadence I2C controller. This controller is for example found in Xilinx Zynq. Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com --- v3: - incorporate signal handling changes from Mike Looijmans

Re: [PATCH v3 1/2] i2c: Add driver for Cadence I2C controller

2014-04-03 Thread Wolfram Sang
Please don't quote large parts of the message f you are not referring to it. +#ifdef CONFIG_PM_SLEEP +/** + * cdns_i2c_suspend - Suspend method for the driver + * @_dev: Address of the platform_device structure + * Return: 0 always + * + * Put the driver into low power mode. +

Re: [PATCH v3 1/2] i2c: Add driver for Cadence I2C controller

2014-04-03 Thread Michal Simek
On 04/03/2014 09:10 AM, Wolfram Sang wrote: Please don't quote large parts of the message f you are not referring to it. Normally I do it. Forgot sorry. +#ifdef CONFIG_PM_SLEEP +/** + * cdns_i2c_suspend - Suspend method for the driver + * @_dev: Address of the platform_device structure

Re: [PATCH v3 1/2] i2c: Add driver for Cadence I2C controller

2014-04-01 Thread Sören Brinkmann
On Tue, 2014-04-01 at 02:50AM +0200, Wolfram Sang wrote: > On Tue, Mar 11, 2014 at 09:50:12AM -0700, Soren Brinkmann wrote: > > Add a driver for the Cadence I2C controller. This controller is for > > example found in Xilinx Zynq. > > > > Signed-off-by: Soren Brinkmann > > ... > > > +static

Re: [PATCH v3 1/2] i2c: Add driver for Cadence I2C controller

2014-04-01 Thread Sören Brinkmann
On Tue, 2014-04-01 at 02:50AM +0200, Wolfram Sang wrote: On Tue, Mar 11, 2014 at 09:50:12AM -0700, Soren Brinkmann wrote: Add a driver for the Cadence I2C controller. This controller is for example found in Xilinx Zynq. Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com ...

Re: [PATCH v3 1/2] i2c: Add driver for Cadence I2C controller

2014-03-31 Thread Wolfram Sang
On Tue, Mar 11, 2014 at 09:50:12AM -0700, Soren Brinkmann wrote: > Add a driver for the Cadence I2C controller. This controller is for > example found in Xilinx Zynq. > > Signed-off-by: Soren Brinkmann ... > +static irqreturn_t cdns_i2c_isr(int irq, void *ptr) > +{ > + unsigned int

Re: [PATCH v3 1/2] i2c: Add driver for Cadence I2C controller

2014-03-31 Thread Wolfram Sang
On Tue, Mar 11, 2014 at 09:50:12AM -0700, Soren Brinkmann wrote: Add a driver for the Cadence I2C controller. This controller is for example found in Xilinx Zynq. Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com ... +static irqreturn_t cdns_i2c_isr(int irq, void *ptr) +{ +

Re: [PATCH v3 1/2] i2c: Add driver for Cadence I2C controller

2014-03-20 Thread Michal Simek
On 03/11/2014 05:50 PM, Soren Brinkmann wrote: > Add a driver for the Cadence I2C controller. This controller is for > example found in Xilinx Zynq. > > Signed-off-by: Soren Brinkmann > --- > v3: > - incorporate signal handling changes from Mike Looijmans >

Re: [PATCH v3 1/2] i2c: Add driver for Cadence I2C controller

2014-03-20 Thread Michal Simek
On 03/11/2014 05:50 PM, Soren Brinkmann wrote: Add a driver for the Cadence I2C controller. This controller is for example found in Xilinx Zynq. Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com --- v3: - incorporate signal handling changes from Mike Looijmans

Re: [PATCH v3 1/2] i2c: Add driver for Cadence I2C controller

2014-03-19 Thread Sören Brinkmann
ping? Thanks, Sören On Tue, 2014-03-11 at 09:50AM -0700, Soren Brinkmann wrote: > Add a driver for the Cadence I2C controller. This controller is for > example found in Xilinx Zynq. > > Signed-off-by: Soren Brinkmann > --- > v3: > - incorporate signal handling changes from

Re: [PATCH v3 1/2] i2c: Add driver for Cadence I2C controller

2014-03-19 Thread Sören Brinkmann
ping? Thanks, Sören On Tue, 2014-03-11 at 09:50AM -0700, Soren Brinkmann wrote: Add a driver for the Cadence I2C controller. This controller is for example found in Xilinx Zynq. Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com --- v3: - incorporate signal

[PATCH v3 1/2] i2c: Add driver for Cadence I2C controller

2014-03-11 Thread Soren Brinkmann
Add a driver for the Cadence I2C controller. This controller is for example found in Xilinx Zynq. Signed-off-by: Soren Brinkmann --- v3: - incorporate signal handling changes from Mike Looijmans (https://lkml.org/lkml/2014/3/11/64) v2: - make driver depend on COMMON_CLK instead of

[PATCH v3 1/2] i2c: Add driver for Cadence I2C controller

2014-03-11 Thread Soren Brinkmann
Add a driver for the Cadence I2C controller. This controller is for example found in Xilinx Zynq. Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com --- v3: - incorporate signal handling changes from Mike Looijmans mike.looijm...@topic.nl (https://lkml.org/lkml/2014/3/11/64) v2: -