Re: [PATCH v3 1/2] iio: adc: mt6360: Add ADC driver for MT6360

2020-09-10 Thread Gene Chen
Gene Chen 於 2020年9月9日 週三 上午7:39寫道： > > Jonathan Cameron 於 2020年9月8日 週二 下午9:00寫道： > > > > ... > > > > > > > > > +#include > > > > > > > +#include > > > > > > > +#include > > > > > > > +#include > > > > > > > +#include > > > > > > > +#include > > > > > > > +#include > > > > > > > +#include

Re: [PATCH v3 1/2] iio: adc: mt6360: Add ADC driver for MT6360

2020-09-09 Thread Jonathan Cameron
On Wed, 9 Sep 2020 07:39:14 +0800 Gene Chen wrote: > Jonathan Cameron 於 2020年9月8日 週二 下午9:00寫道： > > > > ... > > > > > > > > > +#include > > > > > > > +#include > > > > > > > +#include > > > > > > > +#include > > > > > > > +#include > > > > > > > +#include > > > > > > > +#include > > > >

Re: [PATCH v3 1/2] iio: adc: mt6360: Add ADC driver for MT6360

2020-09-09 Thread Gene Chen
Jonathan Cameron 於 2020年9月8日 週二 下午9:00寫道： > > ... > > > > > > > +#include > > > > > > +#include > > > > > > +#include > > > > > > +#include > > > > > > +#include > > > > > > +#include > > > > > > +#include > > > > > > +#include > > > > > > +#include > > > > > > +#include > > > > > > +#in

Re: [PATCH v3 1/2] iio: adc: mt6360: Add ADC driver for MT6360

2020-09-08 Thread Jonathan Cameron
... > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > + > > > > >

Re: [PATCH v3 1/2] iio: adc: mt6360: Add ADC driver for MT6360

2020-09-08 Thread Gene Chen
Jonathan Cameron 於 2020年9月8日 週二 下午5:08寫道： > > On Tue, 8 Sep 2020 14:17:42 +0800 > Gene Chen wrote: > > > Jonathan Cameron 於 2020年8月30日 週日 上午1:12寫道： > > > > > > On Mon, 24 Aug 2020 17:06:24 +0800 > > > Gene Chen wrote: > > > > > > > From: Gene Chen > > > > > > > > Add MT6360 ADC driver include

Re: [PATCH v3 1/2] iio: adc: mt6360: Add ADC driver for MT6360

2020-09-08 Thread Jonathan Cameron
On Tue, 8 Sep 2020 14:17:42 +0800 Gene Chen wrote: > Jonathan Cameron 於 2020年8月30日 週日 上午1:12寫道： > > > > On Mon, 24 Aug 2020 17:06:24 +0800 > > Gene Chen wrote: > > > > > From: Gene Chen > > > > > > Add MT6360 ADC driver include Charger Current, Voltage, and > > > Temperature. > > > > > > Sig

Re: [PATCH v3 1/2] iio: adc: mt6360: Add ADC driver for MT6360

2020-09-08 Thread Andy Shevchenko
On Tue, Sep 8, 2020 at 9:19 AM Gene Chen wrote: > Jonathan Cameron 於 2020年8月30日 週日 上午1:12寫道： > > On Mon, 24 Aug 2020 17:06:24 +0800 > > Gene Chen wrote: > > A few comments inline. The big one centres on why we can't > > expose the channels as _raw, _offset and _scale? > > > > I think i have 3

Re: [PATCH v3 1/2] iio: adc: mt6360: Add ADC driver for MT6360

2020-09-07 Thread Gene Chen
Jonathan Cameron 於 2020年8月30日 週日 上午1:12寫道： > > On Mon, 24 Aug 2020 17:06:24 +0800 > Gene Chen wrote: > > > From: Gene Chen > > > > Add MT6360 ADC driver include Charger Current, Voltage, and > > Temperature. > > > > Signed-off-by: Gene Chen > Hi Gene, > > A few comments inline. The big one cen

Re: [PATCH v3 1/2] iio: adc: mt6360: Add ADC driver for MT6360

2020-08-30 Thread Andy Shevchenko
On Mon, Aug 24, 2020 at 12:07 PM Gene Chen wrote: > > Add MT6360 ADC driver include Charger Current, Voltage, and include -> that includes > Temperature. ... > + help > + Say Y here to enable MT6360 ADC Part. > + Integrated for System Monitoring include > + Charge

Re: [PATCH v3 1/2] iio: adc: mt6360: Add ADC driver for MT6360

2020-08-29 Thread Jonathan Cameron
On Mon, 24 Aug 2020 17:06:24 +0800 Gene Chen wrote: > From: Gene Chen > > Add MT6360 ADC driver include Charger Current, Voltage, and > Temperature. > > Signed-off-by: Gene Chen Hi Gene, A few comments inline. The big one centres on why we can't expose the channels as _raw, _offset and _sca

Re: [PATCH v3 1/2] iio: adc: mt6360: Add ADC driver for MT6360

2020-08-27 Thread kernel test robot
Hi Gene, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on iio/togreg] [also build test WARNING on v5.9-rc2 next-20200827] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented i

[PATCH v3 1/2] iio: adc: mt6360: Add ADC driver for MT6360

2020-08-24 Thread Gene Chen
From: Gene Chen Add MT6360 ADC driver include Charger Current, Voltage, and Temperature. Signed-off-by: Gene Chen --- drivers/iio/adc/Kconfig | 11 ++ drivers/iio/adc/Makefile | 1 + drivers/iio/adc/mt6360-adc.c | 366 +++ 3 files changed, 37