Re: [PATCH v3 1/2] leds: pwm: Allow automatic labels for DT based devices

Hi! > >>> pwm_init_state(led_data->pwm, _data->pwmstate); > >>>- ret = devm_led_classdev_register(dev, _data->cdev); > >>>+ if (fwnode) { > >>>+ init_data.fwnode = fwnode; > >>>+ ret = devm_led_classdev_register_ext(dev, _data->cdev, > >>>+

Re: [PATCH v3 1/2] leds: pwm: Allow automatic labels for DT based devices

Hi Alexander, On 9/9/20 10:29 PM, Alexander Dahl wrote: Hei hei, On Wed, Sep 09, 2020 at 11:07:36AM +0200, Pavel Machek wrote: Hi! pwm_init_state(led_data->pwm, _data->pwmstate); - ret = devm_led_classdev_register(dev, _data->cdev); + if (fwnode) { +

Re: [PATCH v3 1/2] leds: pwm: Allow automatic labels for DT based devices

Hei hei, On Wed, Sep 09, 2020 at 11:07:36AM +0200, Pavel Machek wrote: > Hi! > > > pwm_init_state(led_data->pwm, _data->pwmstate); > > > > - ret = devm_led_classdev_register(dev, _data->cdev); > > + if (fwnode) { > > + init_data.fwnode = fwnode; > > + ret =

Re: [PATCH v3 1/2] leds: pwm: Allow automatic labels for DT based devices

Hi! > pwm_init_state(led_data->pwm, _data->pwmstate); > > - ret = devm_led_classdev_register(dev, _data->cdev); > + if (fwnode) { > + init_data.fwnode = fwnode; > + ret = devm_led_classdev_register_ext(dev, _data->cdev, > +

[PATCH v3 1/2] leds: pwm: Allow automatic labels for DT based devices

If LEDs are configured through device tree and the property 'label' is omitted, the label is supposed to be generated from the properties 'function' and 'color' if present. While this works fine for e.g. the 'leds-gpio' driver, it did not for 'leds-pwm'. The reason is, you get this label naming