Re: [PATCH v3 1/2] mm, proc: Fix region lost in /proc/self/smaps

2016-09-29 Thread Michal Hocko
On Thu 29-09-16 21:14:40, Robert Hu wrote: > On Mon, 2016-09-26 at 10:46 +0200, Michal Hocko wrote: > > On Fri 23-09-16 17:53:51, Oleg Nesterov wrote: > > > On 09/23, Michal Hocko wrote: > > > > > > > > On Fri 23-09-16 15:56:36, Oleg Nesterov wrote: > > > > > > > > > > I think we can simplify this

Re: [PATCH v3 1/2] mm, proc: Fix region lost in /proc/self/smaps

2016-09-26 Thread Michal Hocko
On Fri 23-09-16 17:53:51, Oleg Nesterov wrote: > On 09/23, Michal Hocko wrote: > > > > On Fri 23-09-16 15:56:36, Oleg Nesterov wrote: > > > > > > I think we can simplify this patch. And imo make it better. How about > > > > it is certainly less subtle because it doesn't report "sub-vmas". > > >

Re: [PATCH v3 1/2] mm, proc: Fix region lost in /proc/self/smaps

2016-09-23 Thread Oleg Nesterov
On 09/23, Michal Hocko wrote: > > On Fri 23-09-16 15:56:36, Oleg Nesterov wrote: > > > > I think we can simplify this patch. And imo make it better. How about > > it is certainly less subtle because it doesn't report "sub-vmas". > > > if (last_addr) { > > vma = find_vma(mm, last_

Re: [PATCH v3 1/2] mm, proc: Fix region lost in /proc/self/smaps

2016-09-23 Thread Michal Hocko
On Fri 23-09-16 15:56:36, Oleg Nesterov wrote: > On 09/23, Robert Ho wrote: > > > > --- a/fs/proc/task_mmu.c > > +++ b/fs/proc/task_mmu.c > > @@ -147,7 +147,7 @@ m_next_vma(struct proc_maps_private *priv, struct > > vm_area_struct *vma) > > static void m_cache_vma(struct seq_file *m, struct vm_ar

Re: [PATCH v3 1/2] mm, proc: Fix region lost in /proc/self/smaps

2016-09-23 Thread Michal Hocko
On Fri 23-09-16 15:50:51, Michal Hocko wrote: > On Fri 23-09-16 21:12:33, Robert Ho wrote: [...] > > @@ -786,7 +791,7 @@ static int show_smap(struct seq_file *m, void *v, int > > is_pid) > >"KernelPageSize: %8lu kB\n" > >"MMUPageSize:%8lu kB\n" > >

Re: [PATCH v3 1/2] mm, proc: Fix region lost in /proc/self/smaps

2016-09-23 Thread Oleg Nesterov
On 09/23, Robert Ho wrote: > > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -147,7 +147,7 @@ m_next_vma(struct proc_maps_private *priv, struct > vm_area_struct *vma) > static void m_cache_vma(struct seq_file *m, struct vm_area_struct *vma) > { > if (m->count < m->size) /* vma i

Re: [PATCH v3 1/2] mm, proc: Fix region lost in /proc/self/smaps

2016-09-23 Thread Michal Hocko
On Fri 23-09-16 21:12:33, Robert Ho wrote: > From: Xiao Guangrong > > Recently, Redhat reported that nvml test suite failed on QEMU/KVM, > more detailed info please refer to: >https://bugzilla.redhat.com/show_bug.cgi?id=1365721 > > Actually, this bug is not only for NVDIMM/DAX but also for a

[PATCH v3 1/2] mm, proc: Fix region lost in /proc/self/smaps

2016-09-23 Thread Robert Ho
From: Xiao Guangrong Recently, Redhat reported that nvml test suite failed on QEMU/KVM, more detailed info please refer to: https://bugzilla.redhat.com/show_bug.cgi?id=1365721 Actually, this bug is not only for NVDIMM/DAX but also for any other file systems. This simple test case abstracted f