Re: [PATCH v3 1/2] mm/sparse: Clean up the obsolete code comment

2019-03-30 Thread Mike Rapoport
On Fri, Mar 29, 2019 at 04:29:14PM +0800, Baoquan He wrote: > The code comment above sparse_add_one_section() is obsolete and > incorrect, clean it up and write new one. > > Signed-off-by: Baoquan He Reviewed-by: Mike Rapoport > --- > v2->v3: > Normalize the code comment to use '/**' at 1st

Re: [PATCH v3 1/2] mm/sparse: Clean up the obsolete code comment

2019-03-29 Thread Baoquan He
On 03/29/19 at 11:36am, Oscar Salvador wrote: > > +/** > > + * sparse_add_one_section - add a memory section > > + * @nid: The node to add section on > > + * @start_pfn: start pfn of the memory range > > + * @altmap: device page map > > + * > > + * This is only intended for hotplug. > > + * > > + *

Re: [PATCH v3 1/2] mm/sparse: Clean up the obsolete code comment

2019-03-29 Thread Mukesh Ojha
On 3/29/2019 1:59 PM, Baoquan He wrote: The code comment above sparse_add_one_section() is obsolete and incorrect, clean it up and write new one. Signed-off-by: Baoquan He Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- v2->v3: Normalize the code comment to use '/**' at 1st line of doc

Re: [PATCH v3 1/2] mm/sparse: Clean up the obsolete code comment

2019-03-29 Thread Oscar Salvador
On Fri, Mar 29, 2019 at 04:29:14PM +0800, Baoquan He wrote: > The code comment above sparse_add_one_section() is obsolete and > incorrect, clean it up and write new one. > > Signed-off-by: Baoquan He Reviewed-by: Oscar Salvador > --- > v2->v3: > Normalize the code comment to use '/**' at 1st

Re: [PATCH v3 1/2] mm/sparse: Clean up the obsolete code comment

2019-03-29 Thread Michal Hocko
On Fri 29-03-19 16:29:14, Baoquan He wrote: > The code comment above sparse_add_one_section() is obsolete and > incorrect, clean it up and write new one. > > Signed-off-by: Baoquan He Acked-by: Michal Hocko > --- > v2->v3: > Normalize the code comment to use '/**' at 1st line of doc > abov

[PATCH v3 1/2] mm/sparse: Clean up the obsolete code comment

2019-03-29 Thread Baoquan He
The code comment above sparse_add_one_section() is obsolete and incorrect, clean it up and write new one. Signed-off-by: Baoquan He --- v2->v3: Normalize the code comment to use '/**' at 1st line of doc above function. v1-v2: Add comments to explain what the returned value means for each