Re: [PATCH v3 1/2] objtool: fix failed cold symbol doublefree

2018-11-19 Thread Josh Poimboeuf
On Mon, Nov 12, 2018 at 01:55:18PM +0100, Artem Savkov wrote: > If read_symbols() fails during second list traversal (the one dealing > with ".cold" subfunctions) it frees the symbol, but never deletes it > from the list/hash_table resulting in symbol being freed again in > elf_close(). > >

Re: [PATCH v3 1/2] objtool: fix failed cold symbol doublefree

2018-11-19 Thread Josh Poimboeuf
On Mon, Nov 12, 2018 at 01:55:18PM +0100, Artem Savkov wrote: > If read_symbols() fails during second list traversal (the one dealing > with ".cold" subfunctions) it frees the symbol, but never deletes it > from the list/hash_table resulting in symbol being freed again in > elf_close(). > >

[PATCH v3 1/2] objtool: fix failed cold symbol doublefree

2018-11-12 Thread Artem Savkov
If read_symbols() fails during second list traversal (the one dealing with ".cold" subfunctions) it frees the symbol, but never deletes it from the list/hash_table resulting in symbol being freed again in elf_close(). Fixes: 13810435b9a7 "objtool: Support GCC 8's cold subfunctions" Signed-off-by:

[PATCH v3 1/2] objtool: fix failed cold symbol doublefree

2018-11-12 Thread Artem Savkov
If read_symbols() fails during second list traversal (the one dealing with ".cold" subfunctions) it frees the symbol, but never deletes it from the list/hash_table resulting in symbol being freed again in elf_close(). Fixes: 13810435b9a7 "objtool: Support GCC 8's cold subfunctions" Signed-off-by: