Re: [PATCH v3 1/2] sched/uclamp: Add a new sysctl to control RT default boost value

2020-05-01 Thread Qais Yousef
On 04/30/20 20:21, Dietmar Eggemann wrote: > On 29/04/2020 14:30, Qais Yousef wrote: > > Hi Pavan > > > > On 04/29/20 17:02, Pavan Kondeti wrote: > >> Hi Qais, > >> > >> On Tue, Apr 28, 2020 at 05:41:33PM +0100, Qais Yousef wrote: > > [...] > > >>> @@ -907,8 +935,15 @@ uclamp_tg_restrict(struct

Re: [PATCH v3 1/2] sched/uclamp: Add a new sysctl to control RT default boost value

2020-04-30 Thread Dietmar Eggemann
On 29/04/2020 14:30, Qais Yousef wrote: > Hi Pavan > > On 04/29/20 17:02, Pavan Kondeti wrote: >> Hi Qais, >> >> On Tue, Apr 28, 2020 at 05:41:33PM +0100, Qais Yousef wrote: [...] >>> @@ -907,8 +935,15 @@ uclamp_tg_restrict(struct task_struct *p, enum >>> uclamp_id clamp_id) >>> static inline

Re: [PATCH v3 1/2] sched/uclamp: Add a new sysctl to control RT default boost value

2020-04-29 Thread Qais Yousef
On 04/29/20 20:51, Pavan Kondeti wrote: > As we are copying the sysctl_sched_uclamp_util_min_rt_default value into > p->uclamp_req[UCLAMP_MIN], user gets it when sched_getattr() is called though > sched_setattr() was not called before. I guess that is expected behavior with > your definition of thi

Re: [PATCH v3 1/2] sched/uclamp: Add a new sysctl to control RT default boost value

2020-04-29 Thread Pavan Kondeti
Hi Qais, On Wed, Apr 29, 2020 at 01:30:57PM +0100, Qais Yousef wrote: > Hi Pavan > > On 04/29/20 17:02, Pavan Kondeti wrote: > > Hi Qais, > > > > On Tue, Apr 28, 2020 at 05:41:33PM +0100, Qais Yousef wrote: > > > > [...] > > > > > > > > +static void uclamp_sync_util_min_rt_default(struct tas

Re: [PATCH v3 1/2] sched/uclamp: Add a new sysctl to control RT default boost value

2020-04-29 Thread Qais Yousef
Hi Pavan On 04/29/20 17:02, Pavan Kondeti wrote: > Hi Qais, > > On Tue, Apr 28, 2020 at 05:41:33PM +0100, Qais Yousef wrote: > > [...] > > > > > +static void uclamp_sync_util_min_rt_default(struct task_struct *p) > > +{ > > + struct uclamp_se *uc_se = &p->uclamp_req[UCLAMP_MIN]; > > + > > +

Re: [PATCH v3 1/2] sched/uclamp: Add a new sysctl to control RT default boost value

2020-04-29 Thread Pavan Kondeti
Hi Qais, On Tue, Apr 28, 2020 at 05:41:33PM +0100, Qais Yousef wrote: [...] > > +static void uclamp_sync_util_min_rt_default(struct task_struct *p) > +{ > + struct uclamp_se *uc_se = &p->uclamp_req[UCLAMP_MIN]; > + > + if (unlikely(rt_task(p)) && !uc_se->user_defined) > + u

[PATCH v3 1/2] sched/uclamp: Add a new sysctl to control RT default boost value

2020-04-28 Thread Qais Yousef
RT tasks by default run at the highest capacity/performance level. When uclamp is selected this default behavior is retained by enforcing the requested uclamp.min (p->uclamp_req[UCLAMP_MIN]) of the RT tasks to be uclamp_none(UCLAMP_MAX), which is SCHED_CAPACITY_SCALE; the maximum value. This is al