Re: [PATCH v3 1/2] selftests: watchdog: Validate optional file argument

2019-10-02 Thread shuah
On 10/2/19 4:41 AM, Eugeniu Rosca wrote: Hi Shuah, On Tue, Oct 01, 2019 at 08:41:43PM +, patchwork-bot+linux-kselft...@kernel.org wrote: Hello: This series was applied to shuah/linux-kselftest.git (refs/heads/fixes). On Tue, 17 Sep 2019 20:40:22 +0200 you wrote: From: "George G. Davis"

Re: [PATCH v3 1/2] selftests: watchdog: Validate optional file argument

2019-10-02 Thread Eugeniu Rosca
Hi Shuah, On Tue, Oct 01, 2019 at 08:41:43PM +, patchwork-bot+linux-kselft...@kernel.org wrote: > Hello: > > This series was applied to shuah/linux-kselftest.git (refs/heads/fixes). > > On Tue, 17 Sep 2019 20:40:22 +0200 you wrote: > > From: "George G. Davis" > > > > The newly added

Re: [PATCH v3 1/2] selftests: watchdog: Validate optional file argument

2019-09-19 Thread Eugeniu Rosca
Hi Shuah, On Wed, Sep 18, 2019 at 03:05:33PM -0600, Shuah wrote: [..] > They both look good to me. I will apply these patches once the merge > window closes or when my first pull request to Linus clears. > > You will see a notification when I apply them to kselftest tree. Many thanks for your

Re: [PATCH v3 1/2] selftests: watchdog: Validate optional file argument

2019-09-18 Thread shuah
On 9/18/19 5:33 AM, Eugeniu Rosca wrote: Hi Shuah, On Tue, Sep 17, 2019 at 08:40:22PM +0200, Eugeniu Rosca wrote: From: "George G. Davis" The newly added optional file argument does not validate if the file is indeed a watchdog, e.g.: ./watchdog-test -f /dev/zero Watchdog Ticking Away!

Re: [PATCH v3 1/2] selftests: watchdog: Validate optional file argument

2019-09-18 Thread Eugeniu Rosca
Hi Shuah, On Tue, Sep 17, 2019 at 08:40:22PM +0200, Eugeniu Rosca wrote: > From: "George G. Davis" > > The newly added optional file argument does not validate if the > file is indeed a watchdog, e.g.: > > ./watchdog-test -f /dev/zero > Watchdog Ticking Away! > > Fix it by confirming that

[PATCH v3 1/2] selftests: watchdog: Validate optional file argument

2019-09-17 Thread Eugeniu Rosca
From: "George G. Davis" The newly added optional file argument does not validate if the file is indeed a watchdog, e.g.: ./watchdog-test -f /dev/zero Watchdog Ticking Away! Fix it by confirming that the WDIOC_GETSUPPORT ioctl succeeds. Fixes: c3f2490d6e9257 ("selftests: watchdog: Add