Re: [PATCH v3 1/2] usb: dwc2: gadget: sparse warning of context imbalance

2014-10-23 Thread Greg Kroah-Hartman
On Thu, Oct 23, 2014 at 03:37:14PM +0530, Sudip Mukherjee wrote: > On Fri, Oct 17, 2014 at 07:05:19PM +, Paul Zimmerman wrote: > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > Sent: Friday, October 17, 2014 11:52 AM > > > > > > On Fri, Oct 17, 2014 at 06:50:19PM +, Paul Zimmerman wrote

Re: [PATCH v3 1/2] usb: dwc2: gadget: sparse warning of context imbalance

2014-10-23 Thread Sudip Mukherjee
On Fri, Oct 17, 2014 at 07:05:19PM +, Paul Zimmerman wrote: > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Friday, October 17, 2014 11:52 AM > > > > On Fri, Oct 17, 2014 at 06:50:19PM +, Paul Zimmerman wrote: > > > > From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] > > > >

Re: [PATCH v3 1/2] usb: dwc2: gadget: sparse warning of context imbalance

2014-10-17 Thread Felipe Balbi
On Fri, Oct 17, 2014 at 07:05:19PM +, Paul Zimmerman wrote: > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Friday, October 17, 2014 11:52 AM > > > > On Fri, Oct 17, 2014 at 06:50:19PM +, Paul Zimmerman wrote: > > > > From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] > > > >

RE: [PATCH v3 1/2] usb: dwc2: gadget: sparse warning of context imbalance

2014-10-17 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Friday, October 17, 2014 11:52 AM > > On Fri, Oct 17, 2014 at 06:50:19PM +, Paul Zimmerman wrote: > > > From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] > > > Sent: Thursday, October 16, 2014 9:44 PM > > > > > > sparse was giving the

Re: [PATCH v3 1/2] usb: dwc2: gadget: sparse warning of context imbalance

2014-10-17 Thread Felipe Balbi
On Fri, Oct 17, 2014 at 06:50:19PM +, Paul Zimmerman wrote: > > From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] > > Sent: Thursday, October 16, 2014 9:44 PM > > > > sparse was giving the following warning: > > warning: context imbalance in 's3c_hsotg_ep_enable' > >

RE: [PATCH v3 1/2] usb: dwc2: gadget: sparse warning of context imbalance

2014-10-17 Thread Paul Zimmerman
> From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] > Sent: Thursday, October 16, 2014 9:44 PM > > sparse was giving the following warning: > warning: context imbalance in 's3c_hsotg_ep_enable' > - different lock contexts for basic block > > we were returning

[PATCH v3 1/2] usb: dwc2: gadget: sparse warning of context imbalance

2014-10-16 Thread Sudip Mukherjee
sparse was giving the following warning: warning: context imbalance in 's3c_hsotg_ep_enable' - different lock contexts for basic block we were returning ENOMEM while still holding the spinlock. The sparse warning was fixed by releasing the spinlock before return. S