Re: [PATCH v3 1/2] xen/PVH: Set up GS segment for stack canary

>>> On 17.05.18 at 19:47, wrote: > On 05/17/2018 11:02 AM, Jan Beulich wrote: > On 17.05.18 at 16:47, wrote: >>> @@ -64,6 +67,9 @@ ENTRY(pvh_start_xen) >>> mov %eax,%es >>> mov %eax,%ss >>> >>> + mov $PVH_CANARY_SEL,%eax >>>

Re: [PATCH v3 1/2] xen/PVH: Set up GS segment for stack canary

>>> On 17.05.18 at 19:47, wrote: > On 05/17/2018 11:02 AM, Jan Beulich wrote: > On 17.05.18 at 16:47, wrote: >>> @@ -64,6 +67,9 @@ ENTRY(pvh_start_xen) >>> mov %eax,%es >>> mov %eax,%ss >>> >>> + mov $PVH_CANARY_SEL,%eax >>> + mov %eax,%gs >> I doubt this is needed for 64-bit

Re: [PATCH v3 1/2] xen/PVH: Set up GS segment for stack canary

On 05/17/2018 11:02 AM, Jan Beulich wrote: On 17.05.18 at 16:47, wrote: >> @@ -64,6 +67,9 @@ ENTRY(pvh_start_xen) >> mov %eax,%es >> mov %eax,%ss >> >> +mov $PVH_CANARY_SEL,%eax >> +mov %eax,%gs > I doubt this is needed for 64-bit (you could

Re: [PATCH v3 1/2] xen/PVH: Set up GS segment for stack canary

On 05/17/2018 11:02 AM, Jan Beulich wrote: On 17.05.18 at 16:47, wrote: >> @@ -64,6 +67,9 @@ ENTRY(pvh_start_xen) >> mov %eax,%es >> mov %eax,%ss >> >> +mov $PVH_CANARY_SEL,%eax >> +mov %eax,%gs > I doubt this is needed for 64-bit (you could equally well load zero or

Re: [PATCH v3 1/2] xen/PVH: Set up GS segment for stack canary

>>> On 17.05.18 at 16:47, wrote: > @@ -64,6 +67,9 @@ ENTRY(pvh_start_xen) > mov %eax,%es > mov %eax,%ss > > + mov $PVH_CANARY_SEL,%eax > + mov %eax,%gs I doubt this is needed for 64-bit (you could equally well load zero or leave in place what's

Re: [PATCH v3 1/2] xen/PVH: Set up GS segment for stack canary

>>> On 17.05.18 at 16:47, wrote: > @@ -64,6 +67,9 @@ ENTRY(pvh_start_xen) > mov %eax,%es > mov %eax,%ss > > + mov $PVH_CANARY_SEL,%eax > + mov %eax,%gs I doubt this is needed for 64-bit (you could equally well load zero or leave in place what's there in that case), and

[PATCH v3 1/2] xen/PVH: Set up GS segment for stack canary

We are making calls to C code (e.g. xen_prepare_pvh()) which may use stack canary (stored in GS segment). Signed-off-by: Boris Ostrovsky --- arch/x86/xen/xen-pvh.S | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git

[PATCH v3 1/2] xen/PVH: Set up GS segment for stack canary

We are making calls to C code (e.g. xen_prepare_pvh()) which may use stack canary (stored in GS segment). Signed-off-by: Boris Ostrovsky --- arch/x86/xen/xen-pvh.S | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/arch/x86/xen/xen-pvh.S