RE: [PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep hook in reduced hardware sleep path

2013-07-28 Thread Zheng, Lv
We can find the maintainer's reply that the patch set will be merged. So let me just do a top-based reply here. The examples I showed in the previous emails are just examples that could be used to demonstrate the difficulties on the future ACPICA development that brought by the hooks. Since all

Re: [PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep hook in reduced hardware sleep path

2013-07-26 Thread konrad wilk
On 7/25/2013 10:51 PM, Zheng, Lv wrote: From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] Sent: Thursday, July 25, 2013 8:04 PM CC-ing some of the tboot maintainers. As what I've said, it's up to the others to determine if the patch is OK. I just need to make my concerns visible in t

RE: [PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep hook in reduced hardware sleep path

2013-07-25 Thread Zheng, Lv
> From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > Sent: Thursday, July 25, 2013 8:04 PM > > CC-ing some of the tboot maintainers. > > As what I've said, it's up to the others to determine if the patch is OK. > > I just need to make my concerns visible in the community. :-) > > If I

Re: [PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep hook in reduced hardware sleep path

2013-07-25 Thread Konrad Rzeszutek Wilk
CC-ing some of the tboot maintainers. > As what I've said, it's up to the others to determine if the patch is OK. > I just need to make my concerns visible in the community. :-) If I understand your concerns you don't want the hook to depend on any of the bit manipulations the existing code does f

RE: [PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep hook in reduced hardware sleep path

2013-07-24 Thread Zheng, Lv
@vger.kernel.org] On Behalf Of Konrad Rzeszutek Wilk > Sent: Thursday, July 25, 2013 12:32 AM > To: Ben Guthro > Cc: Moore, Robert; Zheng, Lv; Jan Beulich; Rafael J . Wysocki; > linux-kernel@vger.kernel.org; linux-a...@vger.kernel.org; > xen-de...@lists.xen.org > Subject: Re: [PATC

RE: [PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep hook in reduced hardware sleep path

2013-07-24 Thread Zheng, Lv
utek Wilk > Sent: Thursday, July 25, 2013 12:32 AM > To: Ben Guthro > Cc: Moore, Robert; Zheng, Lv; Jan Beulich; Rafael J . Wysocki; > linux-kernel@vger.kernel.org; linux-a...@vger.kernel.org; > xen-de...@lists.xen.org > Subject: Re: [PATCH v3 1/3] acpi: Call acpi_os_prepare_slee

Re: [PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep hook in reduced hardware sleep path

2013-07-24 Thread Ben Guthro
hanks, >> Bob >> >> >>> -Original Message----- >>> From: Ben Guthro [mailto:benjamin.gut...@citrix.com] >>> Sent: Wednesday, July 24, 2013 6:23 AM >>> To: Moore, Robert >>> Cc: Zheng, Lv; Konrad Rzeszutek Wilk; Jan Beulich; Rafael J . Wysocki; >

RE: [PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep hook in reduced hardware sleep path

2013-07-24 Thread Zheng, Lv
ore, Robert > > Cc: Zheng, Lv; Konrad Rzeszutek Wilk; Jan Beulich; Rafael J . Wysocki; > > linux-kernel@vger.kernel.org; linux-a...@vger.kernel.org; xen- > > de...@lists.xen.org > > Subject: Re: [PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep hook in > > reduced hardware sle

Re: [PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep hook in reduced hardware sleep path

2013-07-24 Thread Konrad Rzeszutek Wilk
On Wed, Jul 24, 2013 at 11:14:06AM -0400, Ben Guthro wrote: > > > On 07/24/2013 10:38 AM, Moore, Robert wrote: > > I haven't found a high-level description of "acpi_os_prepare_sleep", > > perhaps I missed it. > > > > Can someone point me to the overall description of this change and why it > >

Re: [PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep hook in reduced hardware sleep path

2013-07-24 Thread Ben Guthro
t; Sent: Wednesday, July 24, 2013 6:23 AM >> To: Moore, Robert >> Cc: Zheng, Lv; Konrad Rzeszutek Wilk; Jan Beulich; Rafael J . Wysocki; >> linux-kernel@vger.kernel.org; linux-a...@vger.kernel.org; xen- >> de...@lists.xen.org >> Subject: Re: [PATCH v3 1/3] acpi: Cal

RE: [PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep hook in reduced hardware sleep path

2013-07-24 Thread Moore, Robert
lude/acpi/acpiosxf.h - which, I thought was undesirable, in the > >>>> impression that I got from Bob Moore, and Rafael Wysocki (though, > >>>> please correct me on this point, if I have > >>>> misunderstood) > >>>> > >>&

Re: [PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep hook in reduced hardware sleep path

2013-07-24 Thread Ben Guthro
rix.com] >> Sent: Wednesday, July 24, 2013 5:01 AM >> To: Zheng, Lv >> Cc: Konrad Rzeszutek Wilk; Jan Beulich; Rafael J . Wysocki; linux- >> ker...@vger.kernel.org; linux-a...@vger.kernel.org; xen- >> de...@lists.xen.org; Moore, Robert >> Subject: Re: [PATCH v3 1/3]

RE: [PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep hook in reduced hardware sleep path

2013-07-24 Thread Moore, Robert
.@vger.kernel.org; xen- > de...@lists.xen.org; Moore, Robert > Subject: Re: [PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep hook in > reduced hardware sleep path > > > > On 07/24/2013 02:24 AM, Zheng, Lv wrote: > > Hi, > > > > Sorry for the delayed res

Re: [PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep hook in reduced hardware sleep path

2013-07-24 Thread Ben Guthro
p Status Register - WAK_STS (1 bit 7), 15-8 = 7, this >>> definition is >> equivalent to Table 4-16. >>> >>> Thanks and best regards >>> -Lv >>> >>>> -Original Message- >>>> From: linux-acpi-ow...@vger.kernel.org >>>

RE: [PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep hook in reduced hardware sleep path

2013-07-23 Thread Zheng, Lv
s and best regards > > -Lv > > > >> -Original Message- > >> From: linux-acpi-ow...@vger.kernel.org > >> [mailto:linux-acpi-ow...@vger.kernel.org] On Behalf Of Ben Guthro > >> Sent: Wednesday, June 26, 2013 10:06 PM > >> To: Konrad Rzeszutek

Re: [PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep hook in reduced hardware sleep path

2013-07-02 Thread Ben Guthro
r.kernel.org; xen-de...@lists.xen.org Cc: Ben Guthro; Moore, Robert Subject: [PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep hook in reduced hardware sleep path In version 3.4 acpi_os_prepare_sleep() got introduced in parallel with reduced hardware sleep support, and the two changes didn't ge

RE: [PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep hook in reduced hardware sleep path

2013-07-01 Thread Zheng, Lv
esday, June 26, 2013 10:06 PM > To: Konrad Rzeszutek Wilk; Jan Beulich; Rafaell J . Wysocki; > linux-kernel@vger.kernel.org; linux-a...@vger.kernel.org; > xen-de...@lists.xen.org > Cc: Ben Guthro; Moore, Robert > Subject: [PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep

Re: [PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep hook in reduced hardware sleep path

2013-06-26 Thread Rafael J. Wysocki
On Wednesday, June 26, 2013 04:45:53 PM Jan Beulich wrote: > >>> On 26.06.13 at 17:03, Ben Guthro wrote: > > On Wed, Jun 26, 2013 at 10:41 AM, Jan Beulich wrote: > > On 26.06.13 at 16:06, Ben Guthro wrote: > >>> In version 3.4 acpi_os_prepare_sleep() got introduced in parallel with > >>> red

Re: [PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep hook in reduced hardware sleep path

2013-06-26 Thread Jan Beulich
>>> On 26.06.13 at 17:03, Ben Guthro wrote: > On Wed, Jun 26, 2013 at 10:41 AM, Jan Beulich wrote: > On 26.06.13 at 16:06, Ben Guthro wrote: >>> In version 3.4 acpi_os_prepare_sleep() got introduced in parallel with >>> reduced hardware sleep support, and the two changes didn't get >>> synch

Re: [PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep hook in reduced hardware sleep path

2013-06-26 Thread Ben Guthro
On Wed, Jun 26, 2013 at 10:41 AM, Jan Beulich wrote: On 26.06.13 at 16:06, Ben Guthro wrote: >> In version 3.4 acpi_os_prepare_sleep() got introduced in parallel with >> reduced hardware sleep support, and the two changes didn't get >> synchronized: The new code doesn't call the hook functio

Re: [PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep hook in reduced hardware sleep path

2013-06-26 Thread Jan Beulich
>>> On 26.06.13 at 16:06, Ben Guthro wrote: > In version 3.4 acpi_os_prepare_sleep() got introduced in parallel with > reduced hardware sleep support, and the two changes didn't get > synchronized: The new code doesn't call the hook function (if so > requested). Fix this, requiring a parameter to

[PATCH v3 1/3] acpi: Call acpi_os_prepare_sleep hook in reduced hardware sleep path

2013-06-26 Thread Ben Guthro
In version 3.4 acpi_os_prepare_sleep() got introduced in parallel with reduced hardware sleep support, and the two changes didn't get synchronized: The new code doesn't call the hook function (if so requested). Fix this, requiring a parameter to be added to the hook function to distinguish "extende