Re: [PATCH v3 1/3] big key: get rid of stack array allocation

2018-05-11 Thread James Morris
On Tue, 24 Apr 2018, Tycho Andersen wrote: > We're interested in getting rid of all of the stack allocated arrays in the > kernel [1]. This patch simply hardcodes the iv length to match that of the > hardcoded cipher. > > [1]: https://lkml.org/lkml/2018/3/7/621 > > v2: hardcode the length of

Re: [PATCH v3 1/3] big key: get rid of stack array allocation

2018-05-11 Thread James Morris
On Tue, 24 Apr 2018, Tycho Andersen wrote: > We're interested in getting rid of all of the stack allocated arrays in the > kernel [1]. This patch simply hardcodes the iv length to match that of the > hardcoded cipher. > > [1]: https://lkml.org/lkml/2018/3/7/621 > > v2: hardcode the length of

Re: [PATCH v3 1/3] big key: get rid of stack array allocation

2018-05-09 Thread Kees Cook
On Wed, May 9, 2018 at 12:21 PM, James Morris wrote: > On Thu, 10 May 2018, James Morris wrote: > >> > >> > Reviewed-by: Kees Cook >> > >> > James, are these something you can take into your tree? >> >> Sure! > > Although, normally, these would likely

Re: [PATCH v3 1/3] big key: get rid of stack array allocation

2018-05-09 Thread Kees Cook
On Wed, May 9, 2018 at 12:21 PM, James Morris wrote: > On Thu, 10 May 2018, James Morris wrote: > >> > >> > Reviewed-by: Kees Cook >> > >> > James, are these something you can take into your tree? >> >> Sure! > > Although, normally, these would likely come in to mine via David's tree. > > Please

Re: [PATCH v3 1/3] big key: get rid of stack array allocation

2018-05-09 Thread James Morris
On Thu, 10 May 2018, James Morris wrote: > > > > Reviewed-by: Kees Cook > > > > James, are these something you can take into your tree? > > Sure! Although, normally, these would likely come in to mine via David's tree. Please do that unless there's a special case

Re: [PATCH v3 1/3] big key: get rid of stack array allocation

2018-05-09 Thread James Morris
On Thu, 10 May 2018, James Morris wrote: > > > > Reviewed-by: Kees Cook > > > > James, are these something you can take into your tree? > > Sure! Although, normally, these would likely come in to mine via David's tree. Please do that unless there's a special case here. -- James Morris

Re: [PATCH v3 1/3] big key: get rid of stack array allocation

2018-05-09 Thread James Morris
On Tue, 8 May 2018, Kees Cook wrote: > On Tue, Apr 24, 2018 at 1:26 PM, Tycho Andersen wrote: > > We're interested in getting rid of all of the stack allocated arrays in the > > kernel [1]. This patch simply hardcodes the iv length to match that of the > > hardcoded cipher. > > >

Re: [PATCH v3 1/3] big key: get rid of stack array allocation

2018-05-09 Thread James Morris
On Tue, 8 May 2018, Kees Cook wrote: > On Tue, Apr 24, 2018 at 1:26 PM, Tycho Andersen wrote: > > We're interested in getting rid of all of the stack allocated arrays in the > > kernel [1]. This patch simply hardcodes the iv length to match that of the > > hardcoded cipher. > > > > [1]:

Re: [PATCH v3 1/3] big key: get rid of stack array allocation

2018-05-08 Thread Kees Cook
On Tue, Apr 24, 2018 at 1:26 PM, Tycho Andersen wrote: > We're interested in getting rid of all of the stack allocated arrays in the > kernel [1]. This patch simply hardcodes the iv length to match that of the > hardcoded cipher. > > [1]: https://lkml.org/lkml/2018/3/7/621 > > v2:

Re: [PATCH v3 1/3] big key: get rid of stack array allocation

2018-05-08 Thread Kees Cook
On Tue, Apr 24, 2018 at 1:26 PM, Tycho Andersen wrote: > We're interested in getting rid of all of the stack allocated arrays in the > kernel [1]. This patch simply hardcodes the iv length to match that of the > hardcoded cipher. > > [1]: https://lkml.org/lkml/2018/3/7/621 > > v2: hardcode the

Re: [PATCH v3 1/3] big key: get rid of stack array allocation

2018-05-04 Thread Tycho Andersen
Hi, Any thoughts on this series? Thanks, Tycho

Re: [PATCH v3 1/3] big key: get rid of stack array allocation

2018-05-04 Thread Tycho Andersen
Hi, Any thoughts on this series? Thanks, Tycho

[PATCH v3 1/3] big key: get rid of stack array allocation

2018-04-24 Thread Tycho Andersen
We're interested in getting rid of all of the stack allocated arrays in the kernel [1]. This patch simply hardcodes the iv length to match that of the hardcoded cipher. [1]: https://lkml.org/lkml/2018/3/7/621 v2: hardcode the length of the nonce to be the GCM AES IV length, and do a sanity

[PATCH v3 1/3] big key: get rid of stack array allocation

2018-04-24 Thread Tycho Andersen
We're interested in getting rid of all of the stack allocated arrays in the kernel [1]. This patch simply hardcodes the iv length to match that of the hardcoded cipher. [1]: https://lkml.org/lkml/2018/3/7/621 v2: hardcode the length of the nonce to be the GCM AES IV length, and do a sanity