Re: [PATCH v3 1/3] clk: sifive: Extract prci core to common base

2020-11-15 Thread Zong Li
On Thu, Nov 12, 2020 at 2:02 PM Stephen Boyd wrote: > > Quoting Pragnesh Patel (2020-11-11 01:51:17) > > >+#define RCI_GEMGXLPLLCFG1_CKE_SHIFT 24 > > >+#define PRCI_GEMGXLPLLCFG1_CKE_MASK (0x1 << > > >PRCI_GEMGXLPLLCFG1_CKE_SHIFT) > > > > Same here, Other than this > > > > Reviewed-by: Pragnes

Re: [PATCH v3 1/3] clk: sifive: Extract prci core to common base

2020-11-11 Thread Zong Li
gnesh Patel > >; a...@eecs.berkeley.edu; > >mturque...@baylibre.com; Yash Shah ; linux- > >ker...@vger.kernel.org; linux-...@vger.kernel.org; linux- > >ri...@lists.infradead.org > >Cc: Zong Li > >Subject: [PATCH v3 1/3] clk: sifive: Extract prci core to common base >

RE: [PATCH v3 1/3] clk: sifive: Extract prci core to common base

2020-11-11 Thread Pragnesh Patel
.@vger.kernel.org; linux-...@vger.kernel.org; linux- >ri...@lists.infradead.org >Cc: Zong Li >Subject: [PATCH v3 1/3] clk: sifive: Extract prci core to common base > >Extract common core of prci driver to an independent file, it could allow other >chips to reuse it. Separate SoCs-de

[PATCH v3 1/3] clk: sifive: Extract prci core to common base

2020-11-11 Thread Zong Li
Extract common core of prci driver to an independent file, it could allow other chips to reuse it. Separate SoCs-dependent code 'fu540' from prci core, then we can easily add 'fu740' later. Almost these changes are code movement. The different is adding the private data for each SoC use, so it nee