Re: [PATCH v3 1/3] leds: core: Introduce generic pattern interface

2017-12-08 Thread Pavel Machek
Hi! > > > > +KernelVersion: 4.14 > > > > > > And that kernel version is long since released :) > > > > Yeah, the other problem is it has some interesting format with ":|" > > marking repeat, > > So what would you prefer? > > We can either add another file ("pattern_repeat"?) that allows you to

Re: [PATCH v3 1/3] leds: core: Introduce generic pattern interface

2017-11-21 Thread Jacek Anaszewski
Hi Bjorn, I have one general remark below. On 11/15/2017 08:13 AM, Bjorn Andersson wrote: > Some LED controllers have support for autonomously controlling > brightness over time, according to some preprogrammed pattern or > function. > > This adds a new optional operator that LED class drivers c

Re: [PATCH v3 1/3] leds: core: Introduce generic pattern interface

2017-11-20 Thread Bjorn Andersson
On Mon 20 Nov 15:20 PST 2017, Pavel Machek wrote: > On Wed 2017-11-15 08:36:42, Greg KH wrote: > > On Tue, Nov 14, 2017 at 11:13:43PM -0800, Bjorn Andersson wrote: > > > Some LED controllers have support for autonomously controlling > > > brightness over time, according to some preprogrammed patte

Re: [PATCH v3 1/3] leds: core: Introduce generic pattern interface

2017-11-20 Thread Pavel Machek
On Wed 2017-11-15 08:36:42, Greg KH wrote: > On Tue, Nov 14, 2017 at 11:13:43PM -0800, Bjorn Andersson wrote: > > Some LED controllers have support for autonomously controlling > > brightness over time, according to some preprogrammed pattern or > > function. > > > > This adds a new optional opera

Re: [PATCH v3 1/3] leds: core: Introduce generic pattern interface

2017-11-14 Thread Greg KH
On Tue, Nov 14, 2017 at 11:13:43PM -0800, Bjorn Andersson wrote: > Some LED controllers have support for autonomously controlling > brightness over time, according to some preprogrammed pattern or > function. > > This adds a new optional operator that LED class drivers can implement > if they supp

[PATCH v3 1/3] leds: core: Introduce generic pattern interface

2017-11-14 Thread Bjorn Andersson
Some LED controllers have support for autonomously controlling brightness over time, according to some preprogrammed pattern or function. This adds a new optional operator that LED class drivers can implement if they support such functionality as well as a new device attribute to configure the pat