Re: [PATCH v3 1/3] leds: triggers: Allow to switch the trigger to "panic" on a kernel panic

2016-05-06 Thread Ezequiel Garcia
On 6 May 2016 at 06:03, Jacek Anaszewski wrote: > On 04/29/2016 09:20 AM, Jacek Anaszewski wrote: >> >> Hi Ezequiel, >> >> Thanks for the update. It's indeed reasonable to have all the >> switching infrastructure in ledtrig-panic.c. >> >> I've noticed two minor issues

Re: [PATCH v3 1/3] leds: triggers: Allow to switch the trigger to "panic" on a kernel panic

2016-05-06 Thread Ezequiel Garcia
On 6 May 2016 at 06:03, Jacek Anaszewski wrote: > On 04/29/2016 09:20 AM, Jacek Anaszewski wrote: >> >> Hi Ezequiel, >> >> Thanks for the update. It's indeed reasonable to have all the >> switching infrastructure in ledtrig-panic.c. >> >> I've noticed two minor issues below. > > > Since the merge

Re: [PATCH v3 1/3] leds: triggers: Allow to switch the trigger to "panic" on a kernel panic

2016-05-06 Thread Jacek Anaszewski
On 04/29/2016 09:20 AM, Jacek Anaszewski wrote: Hi Ezequiel, Thanks for the update. It's indeed reasonable to have all the switching infrastructure in ledtrig-panic.c. I've noticed two minor issues below. Since the merge window is imminent, I've addressed those issues by myself and applied

Re: [PATCH v3 1/3] leds: triggers: Allow to switch the trigger to "panic" on a kernel panic

2016-05-06 Thread Jacek Anaszewski
On 04/29/2016 09:20 AM, Jacek Anaszewski wrote: Hi Ezequiel, Thanks for the update. It's indeed reasonable to have all the switching infrastructure in ledtrig-panic.c. I've noticed two minor issues below. Since the merge window is imminent, I've addressed those issues by myself and applied

Re: [PATCH v3 1/3] leds: triggers: Allow to switch the trigger to "panic" on a kernel panic

2016-04-29 Thread Jacek Anaszewski
Hi Ezequiel, Thanks for the update. It's indeed reasonable to have all the switching infrastructure in ledtrig-panic.c. I've noticed two minor issues below. On 04/29/2016 12:03 AM, Ezequiel Garcia wrote: This commit adds a new led_cdev flag LED_PANIC_INDICATOR, which allows to mark a specific

Re: [PATCH v3 1/3] leds: triggers: Allow to switch the trigger to "panic" on a kernel panic

2016-04-29 Thread Jacek Anaszewski
Hi Ezequiel, Thanks for the update. It's indeed reasonable to have all the switching infrastructure in ledtrig-panic.c. I've noticed two minor issues below. On 04/29/2016 12:03 AM, Ezequiel Garcia wrote: This commit adds a new led_cdev flag LED_PANIC_INDICATOR, which allows to mark a specific

[PATCH v3 1/3] leds: triggers: Allow to switch the trigger to "panic" on a kernel panic

2016-04-28 Thread Ezequiel Garcia
This commit adds a new led_cdev flag LED_PANIC_INDICATOR, which allows to mark a specific LED to be switched to the "panic" trigger, on a kernel panic. This is useful to allow the user to assign a regular trigger to a given LED, and still blink that LED on a kernel panic. Signed-off-by: Ezequiel

[PATCH v3 1/3] leds: triggers: Allow to switch the trigger to "panic" on a kernel panic

2016-04-28 Thread Ezequiel Garcia
This commit adds a new led_cdev flag LED_PANIC_INDICATOR, which allows to mark a specific LED to be switched to the "panic" trigger, on a kernel panic. This is useful to allow the user to assign a regular trigger to a given LED, and still blink that LED on a kernel panic. Signed-off-by: Ezequiel