Re: [PATCH v3 1/3] nvmem: Update the OF binding to use a subnode for the cells list

2018-06-10 Thread Srinivas Kandagatla
On 10/06/18 12:36, Alban wrote: On Sun, 10 Jun 2018 11:32:36 +0100 Srinivas Kandagatla wrote: On 08/06/18 18:07, Alban wrote: On Fri, 8 Jun 2018 12:34:12 +0100 Srinivas Kandagatla wrote: ... I looked into this. It would work fine for the cells but not so nicely for the nvmem device

Re: [PATCH v3 1/3] nvmem: Update the OF binding to use a subnode for the cells list

2018-06-10 Thread Alban
On Sun, 10 Jun 2018 11:32:36 +0100 Srinivas Kandagatla wrote: > On 08/06/18 18:07, Alban wrote: > > On Fri, 8 Jun 2018 12:34:12 +0100 > > Srinivas Kandagatla wrote: > > > ... > > > > I looked into this. It would work fine for the cells but not so nicely > > for the nvmem device API. The phan

Re: [PATCH v3 1/3] nvmem: Update the OF binding to use a subnode for the cells list

2018-06-10 Thread Srinivas Kandagatla
On 08/06/18 18:07, Alban wrote: On Fri, 8 Jun 2018 12:34:12 +0100 Srinivas Kandagatla wrote: ... I looked into this. It would work fine for the cells but not so nicely for the nvmem device API. The phandle for the nvmem device would have to reference the node passed here and not the real

Re: [PATCH v3 1/3] nvmem: Update the OF binding to use a subnode for the cells list

2018-06-08 Thread Alban
On Fri, 8 Jun 2018 12:34:12 +0100 Srinivas Kandagatla wrote: > >> Can you try this with your original subnode proposal: > >> just pass the subnode node pointer in np of nvmem_config: > >> > >> ->cut< > >> diff --git a/drivers/nvmem/c

Re: [PATCH v3 1/3] nvmem: Update the OF binding to use a subnode for the cells list

2018-06-08 Thread Srinivas Kandagatla
On 08/06/18 11:59, Alban wrote: On Thu, 7 Jun 2018 18:03:16 +0100 Srinivas Kandagatla wrote: On 07/06/18 17:41, Alban wrote: AFAIU the only thing that we disagree on now is if the nodes representing the cells should be direct children of the provider or in a dedicated subnode. For the MTD

Re: [PATCH v3 1/3] nvmem: Update the OF binding to use a subnode for the cells list

2018-06-08 Thread Alban
On Thu, 7 Jun 2018 18:03:16 +0100 Srinivas Kandagatla wrote: > On 07/06/18 17:41, Alban wrote: > > AFAIU the only thing that we disagree on now is if the nodes > > representing the cells should be direct children of the provider > > or in a dedicated subnode. For the MTD case both solution would

Re: [PATCH v3 1/3] nvmem: Update the OF binding to use a subnode for the cells list

2018-06-07 Thread Srinivas Kandagatla
On 07/06/18 17:41, Alban wrote: AFAIU the only thing that we disagree on now is if the nodes representing the cells should be direct children of the provider or in a dedicated subnode. For the MTD case both solution would solve the binding clash. I would really appreciate if the DT people coul

Re: [PATCH v3 1/3] nvmem: Update the OF binding to use a subnode for the cells list

2018-06-07 Thread Alban
On Tue, 1 May 2018 17:49:03 +0100 Srinivas Kandagatla wrote: > On 18/04/18 14:34, Alban wrote: > > On Wed, 18 Apr 2018 13:53:56 +0100 > > Srinivas Kandagatla wrote: > > > >> On 18/04/18 13:32, Alban wrote: > I was also suggesting you to use nvmem-cell subnode, but make it a > prop

Re: [PATCH v3 1/3] nvmem: Update the OF binding to use a subnode for the cells list

2018-05-01 Thread Srinivas Kandagatla
On 18/04/18 14:34, Alban wrote: On Wed, 18 Apr 2018 13:53:56 +0100 Srinivas Kandagatla wrote: On 18/04/18 13:32, Alban wrote: I was also suggesting you to use nvmem-cell subnode, but make it a proper nvmem provider device, rather than reusing its parent device. You would end up some thing

Re: [PATCH v3 1/3] nvmem: Update the OF binding to use a subnode for the cells list

2018-04-18 Thread Alban
On Wed, 18 Apr 2018 13:53:56 +0100 Srinivas Kandagatla wrote: > On 18/04/18 13:32, Alban wrote: > >> I was also suggesting you to use nvmem-cell subnode, but make it a > >> proper nvmem provider device, rather than reusing its parent device. > >> > >> You would end up some thing like this in dt.

Re: [PATCH v3 1/3] nvmem: Update the OF binding to use a subnode for the cells list

2018-04-18 Thread Srinivas Kandagatla
On 18/04/18 13:32, Alban wrote: I was also suggesting you to use nvmem-cell subnode, but make it a proper nvmem provider device, rather than reusing its parent device. You would end up some thing like this in dt. flash@0 { #address-cells = <1>; #size-cells = <1>; compa

Re: [PATCH v3 1/3] nvmem: Update the OF binding to use a subnode for the cells list

2018-04-18 Thread Alban
On Wed, 18 Apr 2018 13:12:48 +0100 Srinivas Kandagatla wrote: > On 18/04/18 12:41, Alban wrote: > > On Tue, 17 Apr 2018 18:00:40 +0200 > > Alban wrote: > > > >> On Tue, 17 Apr 2018 16:44:01 +0100 > >> Srinivas Kandagatla wrote: > >> > >>> Thanks for explaining, > >>> > >>> On 17/04/18 15:5

Re: [PATCH v3 1/3] nvmem: Update the OF binding to use a subnode for the cells list

2018-04-18 Thread Srinivas Kandagatla
On 18/04/18 12:41, Alban wrote: On Tue, 17 Apr 2018 18:00:40 +0200 Alban wrote: On Tue, 17 Apr 2018 16:44:01 +0100 Srinivas Kandagatla wrote: Thanks for explaining, On 17/04/18 15:54, Alban wrote: This will not only allow reading the calibration data from nvmem, but will also create a p

Re: [PATCH v3 1/3] nvmem: Update the OF binding to use a subnode for the cells list

2018-04-18 Thread Alban
On Tue, 17 Apr 2018 18:00:40 +0200 Alban wrote: > On Tue, 17 Apr 2018 16:44:01 +0100 > Srinivas Kandagatla wrote: > > > Thanks for explaining, > > > > On 17/04/18 15:54, Alban wrote: > > > This will not only allow reading the calibration data from nvmem, but > > > will also create a partitio

Re: [PATCH v3 1/3] nvmem: Update the OF binding to use a subnode for the cells list

2018-04-17 Thread Alban
On Tue, 17 Apr 2018 16:44:01 +0100 Srinivas Kandagatla wrote: > Thanks for explaining, > > On 17/04/18 15:54, Alban wrote: > > This will not only allow reading the calibration data from nvmem, but > > will also create a partition on the MTD device, which is not acceptable. > > With my proposed b

Re: [PATCH v3 1/3] nvmem: Update the OF binding to use a subnode for the cells list

2018-04-17 Thread Srinivas Kandagatla
Thanks for explaining, On 17/04/18 15:54, Alban wrote: This will not only allow reading the calibration data from nvmem, but will also create a partition on the MTD device, which is not acceptable. With my proposed binding this would become: flash@0 { #address-cells = <1>; #size

Re: [PATCH v3 1/3] nvmem: Update the OF binding to use a subnode for the cells list

2018-04-17 Thread Alban
On Tue, 17 Apr 2018 13:54:07 +0100 Srinivas Kandagatla wrote: > On 24/03/18 23:24, Alban Bedel wrote: > > Having the cells as subnodes of the provider device without any > > compatible property might clash with other bindings. To avoid this > > problem update the binding to have all the cells in

Re: [PATCH v3 1/3] nvmem: Update the OF binding to use a subnode for the cells list

2018-04-17 Thread Srinivas Kandagatla
On 24/03/18 23:24, Alban Bedel wrote: Having the cells as subnodes of the provider device without any compatible property might clash with other bindings. To avoid this problem update the binding to have all the cells in a 'nvmem-cells' subnode with a 'nvmem-cells' compatible string. This new b

Re: [PATCH v3 1/3] nvmem: Update the OF binding to use a subnode for the cells list

2018-04-17 Thread Alban
On Mon, 16 Apr 2018 16:04:29 -0500 Rob Herring wrote: > On Sun, Mar 25, 2018 at 12:24:57AM +0100, Alban Bedel wrote: > > Having the cells as subnodes of the provider device without any > > compatible property might clash with other bindings. To avoid this > > problem update the binding to have al

Re: [PATCH v3 1/3] nvmem: Update the OF binding to use a subnode for the cells list

2018-04-16 Thread Rob Herring
On Sun, Mar 25, 2018 at 12:24:57AM +0100, Alban Bedel wrote: > Having the cells as subnodes of the provider device without any > compatible property might clash with other bindings. To avoid this > problem update the binding to have all the cells in a 'nvmem-cells' > subnode with a 'nvmem-cells' co

[PATCH v3 1/3] nvmem: Update the OF binding to use a subnode for the cells list

2018-03-24 Thread Alban Bedel
Having the cells as subnodes of the provider device without any compatible property might clash with other bindings. To avoid this problem update the binding to have all the cells in a 'nvmem-cells' subnode with a 'nvmem-cells' compatible string. This new binding guarantee that we can turn any kind