Re: [PATCH v3 1/3] perf annotate: Fix a bug reading link name from a build-id file

2017-03-28 Thread Taeung Song
On 03/28/2017 03:01 AM, Arnaldo Carvalho de Melo wrote: Em Mon, Mar 27, 2017 at 04:10:36PM +0900, Taeung Song escreveu: It is wrong way to read link name from a build-id file. Because a build-id file is not symbolic link but build-id directory of it is symbolic link, so fix it. Ok, applied,

Re: [PATCH v3 1/3] perf annotate: Fix a bug reading link name from a build-id file

2017-03-27 Thread Arnaldo Carvalho de Melo
Em Mon, Mar 27, 2017 at 04:10:36PM +0900, Taeung Song escreveu: > It is wrong way to read link name from a build-id file. > Because a build-id file is not symbolic link > but build-id directory of it is symbolic link, so fix it. Ok, applied, in the past it was always a symlink, but the following c

[PATCH v3 1/3] perf annotate: Fix a bug reading link name from a build-id file

2017-03-27 Thread Taeung Song
It is wrong way to read link name from a build-id file. Because a build-id file is not symbolic link but build-id directory of it is symbolic link, so fix it. For example, if build-id file name gotten from dso__build_id_filename() is as below, /root/.debug/.build-id/4f/75c7d197c951659d1c1b8b5fd