Re: [PATCH v3 1/3] power-domain: add power domain drivers for Rockchip platform

2014-10-17 Thread Geert Uytterhoeven
Hi Ulf, On Thu, Oct 16, 2014 at 3:06 PM, Ulf Hansson wrote: >> + >> + ret = pm_clk_create(dev); >> + if (ret) { >> + dev_err(dev, "pm_clk_create failed %d\n", ret); >> + return; >> + }; >> + >> + while ((clk = of_clk_get(dev->of_node, i++)) && !

Re: [PATCH v3 1/3] power-domain: add power domain drivers for Rockchip platform

2014-10-16 Thread Ulf Hansson
Hi Jinkun, [...] > + > +static int rockchip_pd_power_on(struct generic_pm_domain *domain) > +{ > + int ret = 0; > + struct rockchip_domain *pd = to_rockchip_pd(domain); > + > + if (pd->dev == NULL) > + pr_err("pd->dev is NULL, power on failed!", __func__); > + > +

[PATCH v3 1/3] power-domain: add power domain drivers for Rockchip platform

2014-10-16 Thread jinkun.hong
From: "jinkun.hong" Add power domain drivers based on generic power domain for Rockchip platform, and support RK3288. Signed-off-by: Jack Dai Signed-off-by: jinkun.hong --- Changes in v3: - change use pm_clk_resume() and pm_clk_suspend() Changes in v2: - remove the "pd->pd.of_node = np" a