Re: [PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error

2019-05-23 Thread Heiko Stuebner
Hi Elaine, Am Donnerstag, 23. Mai 2019, 03:34:37 CEST schrieb elaine.zhang: > hi, Heiko & Enric: > > 在 2019/5/22 下午8:27, Heiko Stuebner 写道: > > Hi Enric, > > > > Am Montag, 20. Mai 2019, 15:38:32 CEST schrieb Enric Balletbo Serra: > >> Hi all, > >> > >> As pointed by [1] and [2] this commit, that

Re: [PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error

2019-05-23 Thread Eduardo Valentin
On Thu, May 23, 2019 at 09:34:37AM +0800, elaine.zhang wrote: > hi, Heiko & Enric: > > 在 2019/5/22 下午8:27, Heiko Stuebner 写道: > >Hi Enric, > > > >Am Montag, 20. Mai 2019, 15:38:32 CEST schrieb Enric Balletbo Serra: > >>Hi all, > >> > >>As pointed by [1] and [2] this commit, that now is upstream, b

Re: [PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error

2019-05-22 Thread elaine.zhang
hi, Heiko & Enric: 在 2019/5/22 下午8:27, Heiko Stuebner 写道: Hi Enric, Am Montag, 20. Mai 2019, 15:38:32 CEST schrieb Enric Balletbo Serra: Hi all, As pointed by [1] and [2] this commit, that now is upstream, breaks veyron (rk3288) and kevin (rk3399) boards. The problem is especially critical fo

Re: [PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error

2019-05-22 Thread Heiko Stuebner
Am Mittwoch, 22. Mai 2019, 14:30:16 CEST schrieb Daniel Lezcano: > On 22/05/2019 14:27, Heiko Stuebner wrote: > > [ ... ] > > >> As this change is now in mainline and is causing veyron to hang I'd > >> suggest reverting this change for now. Even fixing the root cause > >> (maybe the one I pointed

Re: [PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error

2019-05-22 Thread Daniel Lezcano
On 22/05/2019 14:27, Heiko Stuebner wrote: [ ... ] >> As this change is now in mainline and is causing veyron to hang I'd >> suggest reverting this change for now. Even fixing the root cause >> (maybe the one I pointed above) after this patch we will have the >> thermal driver to fail because "gp

Re: [PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error

2019-05-22 Thread Heiko Stuebner
Hi Enric, Am Montag, 20. Mai 2019, 15:38:32 CEST schrieb Enric Balletbo Serra: > Hi all, > > As pointed by [1] and [2] this commit, that now is upstream, breaks > veyron (rk3288) and kevin (rk3399) boards. The problem is especially > critical for veyron boards because they don't boot anymore. >

Re: [PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error

2019-05-22 Thread Daniel Lezcano
Elaine, are you taking care of the issue related to this patch. If not fixed, it will be reverted. On 30/04/2019 12:09, Elaine Zhang wrote: > Explicitly use the pinctrl to set/unset the right mode > instead of relying on the pinctrl init mode. > And it requires setting the tshut polarity befor

Re: [PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error

2019-05-20 Thread Enric Balletbo Serra
Hi all, As pointed by [1] and [2] this commit, that now is upstream, breaks veyron (rk3288) and kevin (rk3399) boards. The problem is especially critical for veyron boards because they don't boot anymore. I didn't look deep at the problem but I have some concerns about this patch, see below. [1]

Re: [PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error

2019-04-30 Thread Daniel Lezcano
On 30/04/2019 12:09, Elaine Zhang wrote: > Explicitly use the pinctrl to set/unset the right mode > instead of relying on the pinctrl init mode. > And it requires setting the tshut polarity before select pinctrl. > > When the temperature sensor mode is set to 0, it will automatically > reset the b

[PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error

2019-04-30 Thread Elaine Zhang
Explicitly use the pinctrl to set/unset the right mode instead of relying on the pinctrl init mode. And it requires setting the tshut polarity before select pinctrl. When the temperature sensor mode is set to 0, it will automatically reset the board via the Clock-Reset-Unit (CRU) if the over tempe