Re: [PATCH v3 1/3] vt: preserve unicode values corresponding to screen characters

2018-07-11 Thread Adam Borowski
On Wed, Jul 11, 2018 at 01:39:56PM -0700, Kees Cook wrote: > On Wed, Jul 11, 2018 at 2:18 AM, Greg Kroah-Hartman > wrote: > > On Tue, Jul 10, 2018 at 05:52:01PM -0700, Kees Cook wrote: > >> On Tue, Jun 26, 2018 at 8:56 PM, Nicolas Pitre > >> wrote: > >> > +++ b/drivers/tty/vt/vt.c > >> > [...] >

Re: [PATCH v3 1/3] vt: preserve unicode values corresponding to screen characters

2018-07-11 Thread Kees Cook
On Tue, Jul 10, 2018 at 8:39 PM, Nicolas Pitre wrote: > I am on vacation away from an actual keyboard until next week. Will look at > it then. Awesome; thanks! -Kees -- Kees Cook Pixel Security -- To unsubscribe from this list: send the line "unsubscribe linux-console" in the body of a messag

Re: [PATCH v3 1/3] vt: preserve unicode values corresponding to screen characters

2018-07-11 Thread Kees Cook
On Wed, Jul 11, 2018 at 2:18 AM, Greg Kroah-Hartman wrote: > On Tue, Jul 10, 2018 at 05:52:01PM -0700, Kees Cook wrote: >> On Tue, Jun 26, 2018 at 8:56 PM, Nicolas Pitre >> wrote: >> > The vt code translates UTF-8 strings into glyph index values and stores >> > those glyph values directly in the

Re: [PATCH v3 1/3] vt: preserve unicode values corresponding to screen characters

2018-07-11 Thread Greg Kroah-Hartman
On Tue, Jul 10, 2018 at 05:52:01PM -0700, Kees Cook wrote: > On Tue, Jun 26, 2018 at 8:56 PM, Nicolas Pitre > wrote: > > The vt code translates UTF-8 strings into glyph index values and stores > > those glyph values directly in the screen buffer. Because there can only > > be at most 512 glyphs,

Re: [PATCH v3 1/3] vt: preserve unicode values corresponding to screen characters

2018-07-10 Thread Nicolas Pitre
I am on vacation away from an actual keyboard until next week. Will look at it then. > Le 10 juill. 2018 à 20:52, Kees Cook a écrit : > >> On Tue, Jun 26, 2018 at 8:56 PM, Nicolas Pitre >> wrote: >> The vt code translates UTF-8 strings into glyph index values and stores >> those glyph values

Re: [PATCH v3 1/3] vt: preserve unicode values corresponding to screen characters

2018-07-10 Thread Kees Cook
On Tue, Jun 26, 2018 at 8:56 PM, Nicolas Pitre wrote: > The vt code translates UTF-8 strings into glyph index values and stores > those glyph values directly in the screen buffer. Because there can only > be at most 512 glyphs, it is impossible to represent most unicode > characters, in which case

[PATCH v3 1/3] vt: preserve unicode values corresponding to screen characters

2018-06-26 Thread Nicolas Pitre
The vt code translates UTF-8 strings into glyph index values and stores those glyph values directly in the screen buffer. Because there can only be at most 512 glyphs, it is impossible to represent most unicode characters, in which case a default glyph (often '?') is displayed instead. The original