Re: [PATCH v3 1/4] PCI: pciehp: Add pciehp_set_indicators() to jointly set LED indicators

2019-08-27 Thread Oliver O'Halloran
On Tue, Aug 20, 2019 at 2:07 AM Denis Efremov wrote: > > Add pciehp_set_indicators() to set power and attention indicators with a > single register write. Thus, avoiding waiting twice for Command Complete. > > Signed-off-by: Denis Efremov > --- > drivers/pci/hotplug/pciehp.h | 1 + > driver

Re: [PATCH v3 1/4] PCI: pciehp: Add pciehp_set_indicators() to jointly set LED indicators

2019-08-27 Thread Oliver O'Halloran
On Tue, Aug 20, 2019 at 2:17 AM Denis Efremov wrote: > > Hi, > > On 8/19/19 7:06 PM, Denis Efremov wrote: > On 8/12/19 11:25 AM, sathyanarayanan kuppuswamy wrote: > > Do we need to switch case here ? if (pwr > 0) {} should work right ? > > I saved the switch here from v2. I think switch makes the

Re: [PATCH v3 1/4] PCI: pciehp: Add pciehp_set_indicators() to jointly set LED indicators

2019-08-21 Thread Kuppuswamy Sathyanarayanan
On Mon, Aug 19, 2019 at 07:06:40PM +0300, Denis Efremov wrote: > Add pciehp_set_indicators() to set power and attention indicators with a > single register write. Thus, avoiding waiting twice for Command Complete. > > Signed-off-by: Denis Efremov > --- > drivers/pci/hotplug/pciehp.h | 1 + >

Re: [PATCH v3 1/4] PCI: pciehp: Add pciehp_set_indicators() to jointly set LED indicators

2019-08-19 Thread Denis Efremov
Hi, On 8/19/19 7:06 PM, Denis Efremov wrote: > + switch (pwr) { > + case PCI_EXP_SLTCTL_PWR_IND_ON: > + case PCI_EXP_SLTCTL_PWR_IND_BLINK: > + case PCI_EXP_SLTCTL_PWR_IND_OFF: > + cmd |= pwr; > + mask |= PCI_EX

[PATCH v3 1/4] PCI: pciehp: Add pciehp_set_indicators() to jointly set LED indicators

2019-08-19 Thread Denis Efremov
Add pciehp_set_indicators() to set power and attention indicators with a single register write. Thus, avoiding waiting twice for Command Complete. Signed-off-by: Denis Efremov --- drivers/pci/hotplug/pciehp.h | 1 + drivers/pci/hotplug/pciehp_hpc.c | 29 + includ