Re: [PATCH v3 1/4] iommu: Check IOMMU_DEV_FEAT_AUX feature in aux api's

2020-07-29 Thread Lu Baolu
Hi Alex, On 7/30/20 4:03 AM, Alex Williamson wrote: On Tue, 14 Jul 2020 13:57:00 +0800 Lu Baolu wrote: The iommu aux-domain api's work only when IOMMU_DEV_FEAT_AUX is enabled for the device. Add this check to avoid misuse. Shouldn't this really be the IOMMU driver's responsibility to test?

Re: [PATCH v3 1/4] iommu: Check IOMMU_DEV_FEAT_AUX feature in aux api's

2020-07-29 Thread Alex Williamson
On Tue, 14 Jul 2020 13:57:00 +0800 Lu Baolu wrote: > The iommu aux-domain api's work only when IOMMU_DEV_FEAT_AUX is enabled > for the device. Add this check to avoid misuse. Shouldn't this really be the IOMMU driver's responsibility to test? If nothing else, iommu_dev_feature_enabled() needs

[PATCH v3 1/4] iommu: Check IOMMU_DEV_FEAT_AUX feature in aux api's

2020-07-14 Thread Lu Baolu
The iommu aux-domain api's work only when IOMMU_DEV_FEAT_AUX is enabled for the device. Add this check to avoid misuse. Signed-off-by: Lu Baolu --- drivers/iommu/iommu.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/iommu/iommu.c