Re: [PATCH v3 1/4] lib/string_helpers: export string_units_{2,10} for others

2016-01-23 Thread Andy Shevchenko
On Sat, Jan 23, 2016 at 6:14 PM, James Bottomley wrote: > After two attempts, doesn't it perhaps strike you that a helper > function rather than a direct export would get over this difficulty? Yes, it would. > It might also address the precision problem you introduced. You mean the issue with

Re: [PATCH v3 1/4] lib/string_helpers: export string_units_{2,10} for others

2016-01-23 Thread James Bottomley
On Sat, 2016-01-23 at 16:55 +0200, Andy Shevchenko wrote: > There is one user coming which would like to use those string arrays. > It might > be useful for any other user in the future. > > Signed-off-by: Andy Shevchenko > --- > include/linux/string_helpers.h | 3 +++ > lib/string_helpers.c

[PATCH v3 1/4] lib/string_helpers: export string_units_{2,10} for others

2016-01-23 Thread Andy Shevchenko
There is one user coming which would like to use those string arrays. It might be useful for any other user in the future. Signed-off-by: Andy Shevchenko --- include/linux/string_helpers.h | 3 +++ lib/string_helpers.c | 21 - 2 files changed, 15 insertions(+), 9 d