Re: [PATCH v3 1/4] perf diff: color the Delta column

On Thu, Nov 28, 2013 at 10:54:25PM +0530, Ramkumar Ramachandra wrote: > Jiri Olsa wrote: > > these colors are not consistent with colors in baseline, > > moreover all negative values are shown as red > > > > - please check get_percent_color function (used for baseline), > > it checks the percenta

Re: [PATCH v3 1/4] perf diff: color the Delta column

Jiri Olsa wrote: > these colors are not consistent with colors in baseline, > moreover all negative values are shown as red > > - please check get_percent_color function (used for baseline), > it checks the percentage against following values: > > #define MIN_GREEN 0.5 > #define MIN_RED

Re: [PATCH v3 1/4] perf diff: color the Delta column

On Wed, Nov 27, 2013 at 04:32:31PM +0530, Ramkumar Ramachandra wrote: > Color the numbers in the Delta column either green or red depending on > whether the number is positive or negative. > > Cc: Jiri Olsa > Cc: Namhyung Kim > Cc: Arnaldo Carvalho de Melo > Signed-off-by: Ramkumar Ramachandra

[PATCH v3 1/4] perf diff: color the Delta column

Color the numbers in the Delta column either green or red depending on whether the number is positive or negative. Cc: Jiri Olsa Cc: Namhyung Kim Cc: Arnaldo Carvalho de Melo Signed-off-by: Ramkumar Ramachandra --- tools/perf/builtin-diff.c | 37 - 1 file c