Re: [PATCH v3 1/4] rcu: Add comment documenting how rcu_seq_snap works

2018-05-21 Thread Paul E. McKenney
On Sun, May 20, 2018 at 10:48:26PM -0700, Joel Fernandes wrote: > On Sun, May 20, 2018 at 09:50:25PM -0700, Randy Dunlap wrote: > > On 05/20/2018 09:42 PM, Joel Fernandes wrote: > > > rcu_seq_snap may be tricky to decipher. Lets document how it works with > > > an example to make it easier. > > >

Re: [PATCH v3 1/4] rcu: Add comment documenting how rcu_seq_snap works

2018-05-21 Thread Joe Perches
On Sun, 2018-05-20 at 22:48 -0700, Joel Fernandes wrote: > Also I realize I need some better automated tools to catch these issues > (spelling errors in commit, diffs etc). Probably checkpatch.pl should > have such checks for these common things too. checkpatch already does typo checking using the

Re: [PATCH v3 1/4] rcu: Add comment documenting how rcu_seq_snap works

2018-05-20 Thread Randy Dunlap
On 05/20/2018 10:48 PM, Joel Fernandes wrote: > --8<-- > > From 1c1f8ce04bca656a3c07e555048545d4a59e44cf Mon Sep 17 00:00:00 2001 > From: Joel Fernandes > Date: Sun, 20 May 2018 19:37:18 -0700 > Subject: [PATCH v3.5] rcu: Add comment documenting how rcu_seq_snap works > > rcu_se

Re: [PATCH v3 1/4] rcu: Add comment documenting how rcu_seq_snap works

2018-05-20 Thread Joel Fernandes
On Sun, May 20, 2018 at 09:50:25PM -0700, Randy Dunlap wrote: > On 05/20/2018 09:42 PM, Joel Fernandes wrote: > > rcu_seq_snap may be tricky to decipher. Lets document how it works with > > an example to make it easier. > > > > Signed-off-by: Joel Fernandes (Google) > > --- > > kernel/rcu/rcu.h

Re: [PATCH v3 1/4] rcu: Add comment documenting how rcu_seq_snap works

2018-05-20 Thread Randy Dunlap
On 05/20/2018 09:42 PM, Joel Fernandes wrote: > rcu_seq_snap may be tricky to decipher. Lets document how it works with > an example to make it easier. > > Signed-off-by: Joel Fernandes (Google) > --- > kernel/rcu/rcu.h | 33 - > 1 file changed, 32 insertions(+),

[PATCH v3 1/4] rcu: Add comment documenting how rcu_seq_snap works

2018-05-20 Thread Joel Fernandes
rcu_seq_snap may be tricky to decipher. Lets document how it works with an example to make it easier. Signed-off-by: Joel Fernandes (Google) --- kernel/rcu/rcu.h | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/kernel/rcu/rcu.h b/kernel/rcu/rc