Re: [PATCH v3 1/5] perf util: Cleanup and refactor block info functions

2019-10-23 Thread Jin, Yao
On 10/23/2019 7:37 PM, Jiri Olsa wrote: On Tue, Oct 22, 2019 at 04:07:06PM +0800, Jin Yao wrote: SNIP -static int filter_cb(struct hist_entry *he, void *arg __maybe_unused) -{ - /* Skip the calculation of column length in output_resort */ - he->filtered = true; - return

Re: [PATCH v3 1/5] perf util: Cleanup and refactor block info functions

2019-10-23 Thread Jiri Olsa
On Tue, Oct 22, 2019 at 04:07:06PM +0800, Jin Yao wrote: SNIP > > -static int filter_cb(struct hist_entry *he, void *arg __maybe_unused) > -{ > - /* Skip the calculation of column length in output_resort */ > - he->filtered = true; > - return 0; > -} please move this change into se

[PATCH v3 1/5] perf util: Cleanup and refactor block info functions

2019-10-22 Thread Jin Yao
We have already implemented some block-info related functions. Now it's time to do some cleanup, refactoring and move the functions and structures to new block-info.h/block-info.c. v3: --- 1. Rename the patch title 2. Rename from block.h/block.c to block-info.h/block-info.c 3. Move more commo