Re: [PATCH v3 1/5] soc: qcom: Introduce QMI encoder/decoder

2017-11-16 Thread Bjorn Andersson
On Thu 16 Nov 04:10 PST 2017, Srinivas Kandagatla wrote: > On 15/11/17 20:10, Bjorn Andersson wrote: [..] > > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig > > index b00bccddcd3b..91b70b170a82 100644 > > --- a/drivers/soc/qcom/Kconfig > > +++ b/drivers/soc/qcom/Kconfig > > @@ -35

Re: [PATCH v3 1/5] soc: qcom: Introduce QMI encoder/decoder

2017-11-16 Thread Chris Lew
On 11/15/2017 9:42 PM, Bjorn Andersson wrote: On Wed 15 Nov 12:10 PST 2017, Bjorn Andersson wrote: diff --git a/drivers/soc/qcom/qmi_encdec.c b/drivers/soc/qcom/qmi_encdec.c [..] +void *qmi_encode_message(int type, unsigned int msg_id, size_t *len, +unsigned int txn_i

Re: [PATCH v3 1/5] soc: qcom: Introduce QMI encoder/decoder

2017-11-16 Thread Srinivas Kandagatla
On 15/11/17 20:10, Bjorn Andersson wrote: Add the helper library for encoding and decoding QMI encoded messages. The implementation is taken from lib/qmi_encdec.c of the Qualcomm kernel (msm-3.18). Modifications has been made to the public API, source buffers has been made const and the debug-

Re: [PATCH v3 1/5] soc: qcom: Introduce QMI encoder/decoder

2017-11-15 Thread Bjorn Andersson
On Wed 15 Nov 12:10 PST 2017, Bjorn Andersson wrote: > diff --git a/drivers/soc/qcom/qmi_encdec.c b/drivers/soc/qcom/qmi_encdec.c [..] > +void *qmi_encode_message(int type, unsigned int msg_id, size_t *len, > + unsigned int txn_id, struct qmi_elem_info *ei, > +

[PATCH v3 1/5] soc: qcom: Introduce QMI encoder/decoder

2017-11-15 Thread Bjorn Andersson
Add the helper library for encoding and decoding QMI encoded messages. The implementation is taken from lib/qmi_encdec.c of the Qualcomm kernel (msm-3.18). Modifications has been made to the public API, source buffers has been made const and the debug-logging part was omitted, for now. Signed-off