Re: [PATCH v3 1/5] sound: pci: ctxfi: added reference of snd_card

2014-09-22 Thread Sudip Mukherjee
On Mon, Sep 22, 2014 at 10:21:19AM +0200, Takashi Iwai wrote: > At Mon, 22 Sep 2014 13:45:41 +0530, > Sudip Mukherjee wrote: > > > > On Mon, Sep 22, 2014 at 09:04:53AM +0200, Takashi Iwai wrote: > > > At Sun, 21 Sep 2014 21:33:37 +0530, > > > Sudip Mukherjee wrote: > > > > > > > > added and initi

Re: [PATCH v3 1/5] sound: pci: ctxfi: added reference of snd_card

2014-09-22 Thread Takashi Iwai
At Mon, 22 Sep 2014 13:45:41 +0530, Sudip Mukherjee wrote: > > On Mon, Sep 22, 2014 at 09:04:53AM +0200, Takashi Iwai wrote: > > At Sun, 21 Sep 2014 21:33:37 +0530, > > Sudip Mukherjee wrote: > > > > > > added and initialized a pointer of snd_card in the struct hw to get a > > > reference of > >

Re: [PATCH v3 1/5] sound: pci: ctxfi: added reference of snd_card

2014-09-22 Thread Sudip Mukherjee
On Mon, Sep 22, 2014 at 09:04:53AM +0200, Takashi Iwai wrote: > At Sun, 21 Sep 2014 21:33:37 +0530, > Sudip Mukherjee wrote: > > > > added and initialized a pointer of snd_card in the struct hw to get a > > reference of > > the card in other functions > > You need to explain why this change is n

Re: [PATCH v3 1/5] sound: pci: ctxfi: added reference of snd_card

2014-09-22 Thread Takashi Iwai
At Sun, 21 Sep 2014 21:33:37 +0530, Sudip Mukherjee wrote: > > added and initialized a pointer of snd_card in the struct hw to get a > reference of > the card in other functions You need to explain why this change is needed. The above text shows what it'd do, but it doesn't give any explanation

[PATCH v3 1/5] sound: pci: ctxfi: added reference of snd_card

2014-09-21 Thread Sudip Mukherjee
added and initialized a pointer of snd_card in the struct hw to get a reference of the card in other functions Signed-off-by: Sudip Mukherjee --- sound/pci/ctxfi/ctatc.c | 1 + sound/pci/ctxfi/cthardware.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/sound/pci/ctxfi/ctatc.c b/sou