Re: [PATCH v3 1/6] at_hdmac: move to generic DMA binding

2013-04-30 Thread Vinod Koul
On Mon, Apr 22, 2013 at 12:22:32PM +0200, Nicolas Ferre wrote: > On 04/19/2013 11:11 AM, ludovic.desroc...@atmel.com : > > From: Ludovic Desroches > > > > Update at_hdmac driver to support generic DMA device tree binding. Devices > > can still request channel with dma_request_channel() then it

Re: [PATCH v3 1/6] at_hdmac: move to generic DMA binding

2013-04-30 Thread Vinod Koul
On Mon, Apr 22, 2013 at 12:22:32PM +0200, Nicolas Ferre wrote: On 04/19/2013 11:11 AM, ludovic.desroc...@atmel.com : From: Ludovic Desroches ludovic.desroc...@atmel.com Update at_hdmac driver to support generic DMA device tree binding. Devices can still request channel with

Re: [PATCH v3 1/6] at_hdmac: move to generic DMA binding

2013-04-29 Thread Nicolas Ferre
On 04/23/2013 05:44 AM, Vinod Koul : > On Mon, Apr 22, 2013 at 12:22:32PM +0200, Nicolas Ferre wrote: >> On 04/19/2013 11:11 AM, ludovic.desroc...@atmel.com : >>> From: Ludovic Desroches > >>> +#ifdef CONFIG_OF >>> +static bool at_dma_filter(struct dma_chan *chan, void *slave) > this is not

Re: [PATCH v3 1/6] at_hdmac: move to generic DMA binding

2013-04-29 Thread Nicolas Ferre
On 04/23/2013 05:44 AM, Vinod Koul : On Mon, Apr 22, 2013 at 12:22:32PM +0200, Nicolas Ferre wrote: On 04/19/2013 11:11 AM, ludovic.desroc...@atmel.com : From: Ludovic Desroches ludovic.desroc...@atmel.com +#ifdef CONFIG_OF +static bool at_dma_filter(struct dma_chan *chan, void *slave)

Re: [PATCH v3 1/6] at_hdmac: move to generic DMA binding

2013-04-22 Thread Vinod Koul
On Mon, Apr 22, 2013 at 12:22:32PM +0200, Nicolas Ferre wrote: > On 04/19/2013 11:11 AM, ludovic.desroc...@atmel.com : > > From: Ludovic Desroches > > +#ifdef CONFIG_OF > > +static bool at_dma_filter(struct dma_chan *chan, void *slave) this is not defined for else case here. Also this could be

Re: [PATCH v3 1/6] at_hdmac: move to generic DMA binding

2013-04-22 Thread Nicolas Ferre
On 04/19/2013 11:11 AM, ludovic.desroc...@atmel.com : > From: Ludovic Desroches > > Update at_hdmac driver to support generic DMA device tree binding. Devices > can still request channel with dma_request_channel() then it doesn't break > DMA for non DT boards. > > Signed-off-by: Ludovic

Re: [PATCH v3 1/6] at_hdmac: move to generic DMA binding

2013-04-22 Thread Nicolas Ferre
On 04/19/2013 11:11 AM, ludovic.desroc...@atmel.com : From: Ludovic Desroches ludovic.desroc...@atmel.com Update at_hdmac driver to support generic DMA device tree binding. Devices can still request channel with dma_request_channel() then it doesn't break DMA for non DT boards.

Re: [PATCH v3 1/6] at_hdmac: move to generic DMA binding

2013-04-22 Thread Vinod Koul
On Mon, Apr 22, 2013 at 12:22:32PM +0200, Nicolas Ferre wrote: On 04/19/2013 11:11 AM, ludovic.desroc...@atmel.com : From: Ludovic Desroches ludovic.desroc...@atmel.com +#ifdef CONFIG_OF +static bool at_dma_filter(struct dma_chan *chan, void *slave) this is not defined for else case here.