Re: [PATCH v3 1/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

2017-12-20 Thread Patrick Bellasi
On 20-Dec 15:33, Peter Zijlstra wrote: > On Thu, Nov 30, 2017 at 11:47:18AM +, Patrick Bellasi wrote: > > Currently, sg_cpu's flags are set to the value defined by the last call > > of the cpufreq_update_util(); for RT/DL classes this corresponds to the > > SCHED_CPUFREQ_{RT/DL} flags always be

Re: [PATCH v3 1/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

2017-12-20 Thread Peter Zijlstra
On Thu, Nov 30, 2017 at 11:47:18AM +, Patrick Bellasi wrote: > Currently, sg_cpu's flags are set to the value defined by the last call > of the cpufreq_update_util(); for RT/DL classes this corresponds to the > SCHED_CPUFREQ_{RT/DL} flags always being set. > > When multiple CPUs share the same

Re: [PATCH v3 1/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

2017-12-13 Thread Viresh Kumar
On 12-12-17, 15:16, Patrick Bellasi wrote: > Since you are already changing some flags position, maybe we can have > a better organization by using lower flags for "general bits" and > higher ones for class specific, i.e. > > #define SCHED_CPUFREQ_CLEAR (1U << 0) > #define SCHED_CPUFREQ_IOWAIT

Re: [PATCH v3 1/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

2017-12-12 Thread Patrick Bellasi
On 12-Dec 15:56, Juri Lelli wrote: > On 12/12/17 20:10, Viresh Kumar wrote: > > On 12-12-17, 14:38, Juri Lelli wrote: > > > Hi Viresh, > > > > > > On 12/12/17 17:07, Viresh Kumar wrote: > > > > > > [...] > > > > > > > From: Viresh Kumar > > > > Date: Tue, 12 Dec 2017 15:43:26 +0530 > > > > Subj

Re: [PATCH v3 1/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

2017-12-12 Thread Patrick Bellasi
Hi Viresh, On 12-Dec 17:07, Viresh Kumar wrote: > On 07-12-17, 12:45, Patrick Bellasi wrote: > > On 07-Dec 10:31, Viresh Kumar wrote: [...] > I think its important to fix the basic mechanism of util update than fixing > corner cases with workarounds. I attempted a simpler approach (at least > ac

Re: [PATCH v3 1/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

2017-12-12 Thread Juri Lelli
On 12/12/17 20:10, Viresh Kumar wrote: > On 12-12-17, 14:38, Juri Lelli wrote: > > Hi Viresh, > > > > On 12/12/17 17:07, Viresh Kumar wrote: > > > > [...] > > > > > From: Viresh Kumar > > > Date: Tue, 12 Dec 2017 15:43:26 +0530 > > > Subject: [PATCH] sched: Keep track of cpufreq utilization upd

Re: [PATCH v3 1/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

2017-12-12 Thread Viresh Kumar
On 12-12-17, 14:38, Juri Lelli wrote: > Hi Viresh, > > On 12/12/17 17:07, Viresh Kumar wrote: > > [...] > > > From: Viresh Kumar > > Date: Tue, 12 Dec 2017 15:43:26 +0530 > > Subject: [PATCH] sched: Keep track of cpufreq utilization update flags > > > > Currently the schedutil governor overwri

Re: [PATCH v3 1/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

2017-12-12 Thread Juri Lelli
Hi Viresh, On 12/12/17 17:07, Viresh Kumar wrote: [...] > From: Viresh Kumar > Date: Tue, 12 Dec 2017 15:43:26 +0530 > Subject: [PATCH] sched: Keep track of cpufreq utilization update flags > > Currently the schedutil governor overwrites the sg_cpu->flags field on > every call to the utilizati

Re: [PATCH v3 1/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

2017-12-12 Thread Viresh Kumar
On 07-12-17, 12:45, Patrick Bellasi wrote: > On 07-Dec 10:31, Viresh Kumar wrote: > > We posted some comments on V2 for this particular patch suggesting > > some improvements. The patch hasn't changed at all and you haven't > > replied to few of those suggestions as well. Any particular reason for

Re: [PATCH v3 1/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

2017-12-07 Thread Dietmar Eggemann
On 12/07/2017 01:45 PM, Patrick Bellasi wrote: Hi Viresh, On 07-Dec 10:31, Viresh Kumar wrote: On 30-11-17, 11:47, Patrick Bellasi wrote: [...] We posted some comments on V2 for this particular patch suggesting some improvements. The patch hasn't changed at all and you haven't replied to fe

Re: [PATCH v3 1/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

2017-12-07 Thread Patrick Bellasi
Hi Viresh, On 07-Dec 10:31, Viresh Kumar wrote: > On 30-11-17, 11:47, Patrick Bellasi wrote: > > diff --git a/include/linux/sched/cpufreq.h b/include/linux/sched/cpufreq.h > > index d1ad3d825561..bb5f778db023 100644 > > --- a/include/linux/sched/cpufreq.h > > +++ b/include/linux/sched/cpufreq.h >

Re: [PATCH v3 1/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

2017-12-06 Thread Viresh Kumar
On 30-11-17, 11:47, Patrick Bellasi wrote: > diff --git a/include/linux/sched/cpufreq.h b/include/linux/sched/cpufreq.h > index d1ad3d825561..bb5f778db023 100644 > --- a/include/linux/sched/cpufreq.h > +++ b/include/linux/sched/cpufreq.h > @@ -11,6 +11,7 @@ > #define SCHED_CPUFREQ_RT (1U << 0)

Re: [PATCH v3 1/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

2017-11-30 Thread Juri Lelli
On 30/11/17 16:19, Patrick Bellasi wrote: > On 30-Nov 17:02, Juri Lelli wrote: > > On 30/11/17 15:41, Patrick Bellasi wrote: > > > On 30-Nov 14:12, Juri Lelli wrote: > > > > Hi, > > > > > > > > On 30/11/17 11:47, Patrick Bellasi wrote: > > > > > > > > [...] > > > > > > > > > diff --git a/kernel/

Re: [PATCH v3 1/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

2017-11-30 Thread Patrick Bellasi
On 30-Nov 17:02, Juri Lelli wrote: > On 30/11/17 15:41, Patrick Bellasi wrote: > > On 30-Nov 14:12, Juri Lelli wrote: > > > Hi, > > > > > > On 30/11/17 11:47, Patrick Bellasi wrote: > > > > > > [...] > > > > > > > diff --git a/kernel/sched/cpufreq_schedutil.c > > > > b/kernel/sched/cpufreq_sche

Re: [PATCH v3 1/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

2017-11-30 Thread Juri Lelli
On 30/11/17 15:41, Patrick Bellasi wrote: > On 30-Nov 14:12, Juri Lelli wrote: > > Hi, > > > > On 30/11/17 11:47, Patrick Bellasi wrote: > > > > [...] > > > > > diff --git a/kernel/sched/cpufreq_schedutil.c > > > b/kernel/sched/cpufreq_schedutil.c > > > index 2f52ec0f1539..67339ccb5595 100644 >

Re: [PATCH v3 1/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

2017-11-30 Thread Patrick Bellasi
On 30-Nov 14:12, Juri Lelli wrote: > Hi, > > On 30/11/17 11:47, Patrick Bellasi wrote: > > [...] > > > diff --git a/kernel/sched/cpufreq_schedutil.c > > b/kernel/sched/cpufreq_schedutil.c > > index 2f52ec0f1539..67339ccb5595 100644 > > --- a/kernel/sched/cpufreq_schedutil.c > > +++ b/kernel/sch

Re: [PATCH v3 1/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

2017-11-30 Thread Juri Lelli
Hi, On 30/11/17 11:47, Patrick Bellasi wrote: [...] > diff --git a/kernel/sched/cpufreq_schedutil.c > b/kernel/sched/cpufreq_schedutil.c > index 2f52ec0f1539..67339ccb5595 100644 > --- a/kernel/sched/cpufreq_schedutil.c > +++ b/kernel/sched/cpufreq_schedutil.c > @@ -347,6 +347,12 @@ static void

[PATCH v3 1/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter

2017-11-30 Thread Patrick Bellasi
Currently, sg_cpu's flags are set to the value defined by the last call of the cpufreq_update_util(); for RT/DL classes this corresponds to the SCHED_CPUFREQ_{RT/DL} flags always being set. When multiple CPUs share the same frequency domain it might happen that a CPU which executed an RT task, rig