Re: [PATCH v3 1/6] fat: add i_disksize to represent uninitialized size

2014-02-06 Thread Namjae Jeon
2014-02-06, OGAWA Hirofumi : > Namjae Jeon writes: > fat_fill_inode() just set i_disksize to i_size. So, it is not aligned by cluster size or block size. E.g. ->mmu_private = 500. Then, cont_write_begin() can set ->mmu_private to 512 on some case. In this case, f

Re: [PATCH v3 1/6] fat: add i_disksize to represent uninitialized size

2014-02-06 Thread OGAWA Hirofumi
Namjae Jeon writes: >>> fat_fill_inode() just set i_disksize to i_size. So, it is not aligned by >>> cluster size or block size. >>> >>> E.g. ->mmu_private = 500. Then, cont_write_begin() can set ->mmu_private >>> to 512 on some case. In this case, fat_get_block() will not be called, >>> because

Re: [PATCH v3 1/6] fat: add i_disksize to represent uninitialized size

2014-02-05 Thread Namjae Jeon
2014-02-04, OGAWA Hirofumi : > OGAWA Hirofumi writes: > Don't we need to update ->i_disksize after cont_write_begin()? >>> We don't need to update i_disksize after cont_write_begin. >>> It is taken care by the fat_get_block after the allocation. >>> For all write paths we align the mmu_privat

Re: [PATCH v3 1/6] fat: add i_disksize to represent uninitialized size

2014-02-04 Thread OGAWA Hirofumi
OGAWA Hirofumi writes: >>> Don't we need to update ->i_disksize after cont_write_begin()? >> We don't need to update i_disksize after cont_write_begin. >> It is taken care by the fat_get_block after the allocation. >> For all write paths we align the mmu_private and i_disksize from >> fat_fill_in

Re: [PATCH v3 1/6] fat: add i_disksize to represent uninitialized size

2014-02-04 Thread OGAWA Hirofumi
Namjae Jeon writes: > 2014-02-03, OGAWA Hirofumi : >> Namjae Jeon writes: >> >>> From: Namjae Jeon >>> >>> Add i_disksize to represent uninitialized allocated size. >>> And mmu_private represent initialized allocated size. >> >> Don't we need to update ->i_disksize after cont_write_begin()? > W

Re: [PATCH v3 1/6] fat: add i_disksize to represent uninitialized size

2014-02-04 Thread Namjae Jeon
2014-02-03, OGAWA Hirofumi : > Namjae Jeon writes: > >> From: Namjae Jeon >> >> Add i_disksize to represent uninitialized allocated size. >> And mmu_private represent initialized allocated size. > > Don't we need to update ->i_disksize after cont_write_begin()? We don't need to update i_disksize

Re: [PATCH v3 1/6] fat: add i_disksize to represent uninitialized size

2014-02-02 Thread OGAWA Hirofumi
Namjae Jeon writes: > From: Namjae Jeon > > Add i_disksize to represent uninitialized allocated size. > And mmu_private represent initialized allocated size. Don't we need to update ->i_disksize after cont_write_begin()? -- OGAWA Hirofumi -- To unsubscribe from this list: send the line "unsub

[PATCH v3 1/6] fat: add i_disksize to represent uninitialized size

2013-12-24 Thread Namjae Jeon
From: Namjae Jeon Add i_disksize to represent uninitialized allocated size. And mmu_private represent initialized allocated size. Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat --- fs/fat/cache.c |6 +++--- fs/fat/fat.h |3 ++- fs/fat/file.c |4 +++- fs/fat/inode.c |