Re: [PATCH v3 1/6] watchdog: davinci: change driver to use WDT core

2013-11-27 Thread ivan.khoronzhuk
On 11/27/2013 09:04 AM, Guenter Roeck wrote: On 11/26/2013 08:31 PM, Sekhar Nori wrote: On Monday 25 November 2013 07:34 PM, Ivan Khoronzhuk wrote: To reduce code duplicate and increase code readability use WDT core code to handle WDT interface. Remove io_lock as the WDT core uses mutex to

Re: [PATCH v3 1/6] watchdog: davinci: change driver to use WDT core

2013-11-27 Thread ivan.khoronzhuk
On 11/27/2013 09:04 AM, Guenter Roeck wrote: On 11/26/2013 08:31 PM, Sekhar Nori wrote: On Monday 25 November 2013 07:34 PM, Ivan Khoronzhuk wrote: To reduce code duplicate and increase code readability use WDT core code to handle WDT interface. Remove io_lock as the WDT core uses mutex to

Re: [PATCH v3 1/6] watchdog: davinci: change driver to use WDT core

2013-11-26 Thread Guenter Roeck
On 11/26/2013 08:31 PM, Sekhar Nori wrote: On Monday 25 November 2013 07:34 PM, Ivan Khoronzhuk wrote: To reduce code duplicate and increase code readability use WDT core code to handle WDT interface. Remove io_lock as the WDT core uses mutex to lock each wdt device. Remove wdt_state as the

Re: [PATCH v3 1/6] watchdog: davinci: change driver to use WDT core

2013-11-26 Thread Sekhar Nori
On Monday 25 November 2013 07:34 PM, Ivan Khoronzhuk wrote: > To reduce code duplicate and increase code readability use WDT core > code to handle WDT interface. > > Remove io_lock as the WDT core uses mutex to lock each wdt device. > Remove wdt_state as the WDT core tracks state with its own

Re: [PATCH v3 1/6] watchdog: davinci: change driver to use WDT core

2013-11-26 Thread Grygorii Strashko
On 11/26/2013 02:10 PM, Guenter Roeck wrote: On 11/26/2013 03:09 AM, Grygorii Strashko wrote: On 11/25/2013 04:04 PM, Ivan Khoronzhuk wrote: To reduce code duplicate and increase code readability use WDT core code to handle WDT interface. Remove io_lock as the WDT core uses mutex to lock each

Re: [PATCH v3 1/6] watchdog: davinci: change driver to use WDT core

2013-11-26 Thread Guenter Roeck
On 11/26/2013 03:09 AM, Grygorii Strashko wrote: On 11/25/2013 04:04 PM, Ivan Khoronzhuk wrote: To reduce code duplicate and increase code readability use WDT core code to handle WDT interface. Remove io_lock as the WDT core uses mutex to lock each wdt device. Remove wdt_state as the WDT core

Re: [PATCH v3 1/6] watchdog: davinci: change driver to use WDT core

2013-11-26 Thread Grygorii Strashko
On 11/25/2013 04:04 PM, Ivan Khoronzhuk wrote: To reduce code duplicate and increase code readability use WDT core code to handle WDT interface. Remove io_lock as the WDT core uses mutex to lock each wdt device. Remove wdt_state as the WDT core tracks state with its own variable. The

Re: [PATCH v3 1/6] watchdog: davinci: change driver to use WDT core

2013-11-26 Thread Grygorii Strashko
On 11/25/2013 04:04 PM, Ivan Khoronzhuk wrote: To reduce code duplicate and increase code readability use WDT core code to handle WDT interface. Remove io_lock as the WDT core uses mutex to lock each wdt device. Remove wdt_state as the WDT core tracks state with its own variable. The

Re: [PATCH v3 1/6] watchdog: davinci: change driver to use WDT core

2013-11-26 Thread Guenter Roeck
On 11/26/2013 03:09 AM, Grygorii Strashko wrote: On 11/25/2013 04:04 PM, Ivan Khoronzhuk wrote: To reduce code duplicate and increase code readability use WDT core code to handle WDT interface. Remove io_lock as the WDT core uses mutex to lock each wdt device. Remove wdt_state as the WDT core

Re: [PATCH v3 1/6] watchdog: davinci: change driver to use WDT core

2013-11-26 Thread Grygorii Strashko
On 11/26/2013 02:10 PM, Guenter Roeck wrote: On 11/26/2013 03:09 AM, Grygorii Strashko wrote: On 11/25/2013 04:04 PM, Ivan Khoronzhuk wrote: To reduce code duplicate and increase code readability use WDT core code to handle WDT interface. Remove io_lock as the WDT core uses mutex to lock each

Re: [PATCH v3 1/6] watchdog: davinci: change driver to use WDT core

2013-11-26 Thread Sekhar Nori
On Monday 25 November 2013 07:34 PM, Ivan Khoronzhuk wrote: To reduce code duplicate and increase code readability use WDT core code to handle WDT interface. Remove io_lock as the WDT core uses mutex to lock each wdt device. Remove wdt_state as the WDT core tracks state with its own

Re: [PATCH v3 1/6] watchdog: davinci: change driver to use WDT core

2013-11-26 Thread Guenter Roeck
On 11/26/2013 08:31 PM, Sekhar Nori wrote: On Monday 25 November 2013 07:34 PM, Ivan Khoronzhuk wrote: To reduce code duplicate and increase code readability use WDT core code to handle WDT interface. Remove io_lock as the WDT core uses mutex to lock each wdt device. Remove wdt_state as the

Re: [PATCH v3 1/6] watchdog: davinci: change driver to use WDT core

2013-11-25 Thread ivan.khoronzhuk
On 11/25/2013 04:16 PM, Santosh Shilimkar wrote: Ivan, On Monday 25 November 2013 09:04 AM, Ivan Khoronzhuk wrote: To reduce code duplicate and increase code readability use WDT core code to handle WDT interface. Remove io_lock as the WDT core uses mutex to lock each wdt device. Remove

Re: [PATCH v3 1/6] watchdog: davinci: change driver to use WDT core

2013-11-25 Thread Santosh Shilimkar
Ivan, On Monday 25 November 2013 09:04 AM, Ivan Khoronzhuk wrote: > To reduce code duplicate and increase code readability use WDT core > code to handle WDT interface. > > Remove io_lock as the WDT core uses mutex to lock each wdt device. > Remove wdt_state as the WDT core tracks state with its

[PATCH v3 1/6] watchdog: davinci: change driver to use WDT core

2013-11-25 Thread Ivan Khoronzhuk
To reduce code duplicate and increase code readability use WDT core code to handle WDT interface. Remove io_lock as the WDT core uses mutex to lock each wdt device. Remove wdt_state as the WDT core tracks state with its own variable. The watchdog_init_timeout() can read timeout value from

[PATCH v3 1/6] watchdog: davinci: change driver to use WDT core

2013-11-25 Thread Ivan Khoronzhuk
To reduce code duplicate and increase code readability use WDT core code to handle WDT interface. Remove io_lock as the WDT core uses mutex to lock each wdt device. Remove wdt_state as the WDT core tracks state with its own variable. The watchdog_init_timeout() can read timeout value from

Re: [PATCH v3 1/6] watchdog: davinci: change driver to use WDT core

2013-11-25 Thread Santosh Shilimkar
Ivan, On Monday 25 November 2013 09:04 AM, Ivan Khoronzhuk wrote: To reduce code duplicate and increase code readability use WDT core code to handle WDT interface. Remove io_lock as the WDT core uses mutex to lock each wdt device. Remove wdt_state as the WDT core tracks state with its own

Re: [PATCH v3 1/6] watchdog: davinci: change driver to use WDT core

2013-11-25 Thread ivan.khoronzhuk
On 11/25/2013 04:16 PM, Santosh Shilimkar wrote: Ivan, On Monday 25 November 2013 09:04 AM, Ivan Khoronzhuk wrote: To reduce code duplicate and increase code readability use WDT core code to handle WDT interface. Remove io_lock as the WDT core uses mutex to lock each wdt device. Remove