Re: [PATCH v3 1/7] dump_stack: Support adding to the dump stack arch description

2019-02-21 Thread Petr Mladek
On Wed 2019-02-20 14:44:33, Andrea Parri wrote: > > >> > > + * Order the stores above in vsnprintf() vs the store > > >> > > of the > > >> > > + * space below which joins the two strings. Note this > > >> > > doesn't > > >> > > + * make the code truly race free

Re: [PATCH v3 1/7] dump_stack: Support adding to the dump stack arch description

2019-02-20 Thread Andrea Parri
> >> > > + * Order the stores above in vsnprintf() vs the store > >> > > of the > >> > > + * space below which joins the two strings. Note this > >> > > doesn't > >> > > + * make the code truly race free because there is no > >> > > barrier on > >> > > +

Re: [PATCH v3 1/7] dump_stack: Support adding to the dump stack arch description

2019-02-20 Thread Michael Ellerman
Andrea Parri writes: > On Mon, Feb 11, 2019 at 03:38:59PM +0100, Petr Mladek wrote: >> On Mon 2019-02-11 13:50:35, Andrea Parri wrote: >> > On Thu, Feb 07, 2019 at 11:46:29PM +1100, Michael Ellerman wrote: >> > > Arch code can set a "dump stack arch description string" which is >> > > displayed wi

Re: [PATCH v3 1/7] dump_stack: Support adding to the dump stack arch description

2019-02-19 Thread Andrea Parri
On Mon, Feb 11, 2019 at 03:38:59PM +0100, Petr Mladek wrote: > On Mon 2019-02-11 13:50:35, Andrea Parri wrote: > > Hi Michael, > > > > > > On Thu, Feb 07, 2019 at 11:46:29PM +1100, Michael Ellerman wrote: > > > Arch code can set a "dump stack arch description string" which is > > > displayed with

Re: [PATCH v3 1/7] dump_stack: Support adding to the dump stack arch description

2019-02-11 Thread Petr Mladek
On Mon 2019-02-11 13:50:35, Andrea Parri wrote: > Hi Michael, > > > On Thu, Feb 07, 2019 at 11:46:29PM +1100, Michael Ellerman wrote: > > Arch code can set a "dump stack arch description string" which is > > displayed with oops output to describe the hardware platform. > > > > It is useful to in

Re: [PATCH v3 1/7] dump_stack: Support adding to the dump stack arch description

2019-02-11 Thread Andrea Parri
Hi Michael, On Thu, Feb 07, 2019 at 11:46:29PM +1100, Michael Ellerman wrote: > Arch code can set a "dump stack arch description string" which is > displayed with oops output to describe the hardware platform. > > It is useful to initialise this as early as possible, so that an early > oops will

Re: [PATCH v3 1/7] dump_stack: Support adding to the dump stack arch description

2019-02-10 Thread Sergey Senozhatsky
On (02/08/19 13:55), Steven Rostedt wrote: [..] > > + if (len) { > > + /* > > +* Order the stores above in vsnprintf() vs the store of the > > +* space below which joins the two strings. Note this doesn't > > +* make the code truly race free because t

Re: [PATCH v3 1/7] dump_stack: Support adding to the dump stack arch description

2019-02-08 Thread Steven Rostedt
On Thu, Feb 07, 2019 at 11:46:29PM +1100, Michael Ellerman wrote: > > diff --git a/include/linux/printk.h b/include/linux/printk.h > index 77740a506ebb..d5fb4f960271 100644 > --- a/include/linux/printk.h > +++ b/include/linux/printk.h > @@ -198,6 +198,7 @@ u32 log_buf_len_get(void); > void log_bu

Re: [PATCH v3 1/7] dump_stack: Support adding to the dump stack arch description

2019-02-07 Thread Sergey Senozhatsky
Cc-ing Steven https://lore.kernel.org/lkml/20190207124635.3885-1-...@ellerman.id.au/T/#u On (02/07/19 23:46), Michael Ellerman wrote: > Arch code can set a "dump stack arch description string" which is > displayed with oops output to describe the hardware platform. > > It is useful to initiali

[PATCH v3 1/7] dump_stack: Support adding to the dump stack arch description

2019-02-07 Thread Michael Ellerman
Arch code can set a "dump stack arch description string" which is displayed with oops output to describe the hardware platform. It is useful to initialise this as early as possible, so that an early oops will have the hardware description. However in practice we discover the hardware platform in