Re: [PATCH v3 1/7] gpio: gpio-ep93xx: fix BUG_ON port F usage

2021-02-04 Thread Alexander Sverdlin
Hi Nikita, On Thu, 2021-02-04 at 17:00 +0300, nikita.shu...@maquefel.me wrote: > >  I considered your offer of using array with holes. > >    > >  It looks pretty ugly to me, couse it leads to bloated arrays: > >    > >  static unsigned char gpio_int_unmasked[EP93XX_GPIO_CHIP_NUM]; > >  static uns

Re: [PATCH v3 1/7] gpio: gpio-ep93xx: fix BUG_ON port F usage

2021-02-04 Thread Alexander Sverdlin
Hi Nikita, On Thu, 2021-02-04 at 15:55 +0300, nikita.shu...@maquefel.me wrote: > I considered your offer of using array with holes. >   > It looks pretty ugly to me, couse it leads to bloated arrays: >   > static unsigned char gpio_int_unmasked[EP93XX_GPIO_CHIP_NUM]; > static unsigned char gpio_in

Re: [PATCH v3 1/7] gpio: gpio-ep93xx: fix BUG_ON port F usage

2021-01-28 Thread Alexander Sverdlin
Hello Nikita, On Thu, 2021-01-28 at 18:11 +0200, Andy Shevchenko wrote: > > +/* > > + * F Port index in GPIOCHIP'S array is 5 > > + * but we use index 2 for stored values and offsets > > + */ > > +#define EP93XX_GPIO_F_PORT_INDEX 5 > > Hmm... Why not to use an array with holes instead. > > ... >

Re: [PATCH v3 1/7] gpio: gpio-ep93xx: fix BUG_ON port F usage

2021-01-28 Thread Andy Shevchenko
On Thu, Jan 28, 2021 at 2:21 PM Nikita Shubin wrote: > > The port F is index 2 not 5. > > [ cut here ] > kernel BUG at drivers/gpio/gpio-ep93xx.c:64! Perhaps you missed my message, please cut this to have only related information and not be so noisy! > Internal error: Oop

[PATCH v3 1/7] gpio: gpio-ep93xx: fix BUG_ON port F usage

2021-01-28 Thread Nikita Shubin
The port F is index 2 not 5. [ cut here ] kernel BUG at drivers/gpio/gpio-ep93xx.c:64! Internal error: Oops - BUG: 0 [#1] ARM Modules linked in: CPU: 0 PID: 403 Comm: gpio-event-mon Not tainted 5.9.10-00011-ge93e9618628b-dirty #19 Hardware name: Technologic Systems TS-72xx