Re: [PATCH v3 1/8] soc: mediatek: Add PMIC wrapper for MT8135 and MT6397 SoC

2014-12-15 Thread Arnd Bergmann
On Thursday 11 December 2014 18:04:15 Flora Fu wrote: > On Tue, 2014-12-09 at 12:20 +0100, Arnd Bergmann wrote: > > On Tuesday 09 December 2014 11:30:15 Matthias Brugger wrote: > > > 2014-12-09 11:13 GMT+01:00 Sascha Hauer : > > > > On Tue, Dec 09, 2014 at 09:23:18AM +0100, Arnd Bergmann wrote: > >

Re: [PATCH v3 1/8] soc: mediatek: Add PMIC wrapper for MT8135 and MT6397 SoC

2014-12-15 Thread Mark Brown
On Thu, Dec 11, 2014 at 06:04:15PM +0800, Flora Fu wrote: > On Tue, 2014-12-09 at 12:20 +0100, Arnd Bergmann wrote: > > If it looks like i2c messages, would it be more appropriate to make > > it appear as an i2c controller then? > Although the message looks like I2C command, it is not I2C. > Form

Re: [PATCH v3 1/8] soc: mediatek: Add PMIC wrapper for MT8135 and MT6397 SoC

2014-12-11 Thread Flora Fu
Hi, On Tue, 2014-12-09 at 12:20 +0100, Arnd Bergmann wrote: > On Tuesday 09 December 2014 11:30:15 Matthias Brugger wrote: > > 2014-12-09 11:13 GMT+01:00 Sascha Hauer : > > > On Tue, Dec 09, 2014 at 09:23:18AM +0100, Arnd Bergmann wrote: > > >> > > >> I think we have had a similar case recently wh

Re: [PATCH v3 1/8] soc: mediatek: Add PMIC wrapper for MT8135 and MT6397 SoC

2014-12-09 Thread Arnd Bergmann
On Tuesday 09 December 2014 11:30:15 Matthias Brugger wrote: > 2014-12-09 11:13 GMT+01:00 Sascha Hauer : > > On Tue, Dec 09, 2014 at 09:23:18AM +0100, Arnd Bergmann wrote: > >> > >> I think we have had a similar case recently where a controller wasn't > >> actually using I2C, but the sofware protoc

Re: [PATCH v3 1/8] soc: mediatek: Add PMIC wrapper for MT8135 and MT6397 SoC

2014-12-09 Thread Matthias Brugger
2014-12-09 11:13 GMT+01:00 Sascha Hauer : > On Tue, Dec 09, 2014 at 09:23:18AM +0100, Arnd Bergmann wrote: >> On Tuesday 09 December 2014 10:15:37 Flora Fu wrote: >> > Hi, Arnd, >> > >> > On Fri, 2014-12-05 at 11:13 +0100, Arnd Bergmann wrote: >> > > On Friday 05 December 2014 12:07:52 Flora Fu wro

Re: [PATCH v3 1/8] soc: mediatek: Add PMIC wrapper for MT8135 and MT6397 SoC

2014-12-09 Thread Sascha Hauer
On Tue, Dec 09, 2014 at 09:23:18AM +0100, Arnd Bergmann wrote: > On Tuesday 09 December 2014 10:15:37 Flora Fu wrote: > > Hi, Arnd, > > > > On Fri, 2014-12-05 at 11:13 +0100, Arnd Bergmann wrote: > > > On Friday 05 December 2014 12:07:52 Flora Fu wrote: > > > > Add PMIC wrapper of MT8135 to access

Re: [PATCH v3 1/8] soc: mediatek: Add PMIC wrapper for MT8135 and MT6397 SoC

2014-12-09 Thread Arnd Bergmann
On Tuesday 09 December 2014 10:15:37 Flora Fu wrote: > Hi, Arnd, > > On Fri, 2014-12-05 at 11:13 +0100, Arnd Bergmann wrote: > > On Friday 05 December 2014 12:07:52 Flora Fu wrote: > > > Add PMIC wrapper of MT8135 to access MT6397 MFD. > > > > > > Signed-off-by: Flora Fu > > > > > > > Please e

Re: [PATCH v3 1/8] soc: mediatek: Add PMIC wrapper for MT8135 and MT6397 SoC

2014-12-08 Thread Flora Fu
Hi, Arnd, On Fri, 2014-12-05 at 11:13 +0100, Arnd Bergmann wrote: > On Friday 05 December 2014 12:07:52 Flora Fu wrote: > > Add PMIC wrapper of MT8135 to access MT6397 MFD. > > > > Signed-off-by: Flora Fu > > > > Please explain what a PMIC wrapper is and why you need one for MT8135. > I don't

Re: [PATCH v3 1/8] soc: mediatek: Add PMIC wrapper for MT8135 and MT6397 SoC

2014-12-05 Thread Arnd Bergmann
On Friday 05 December 2014 12:07:52 Flora Fu wrote: > Add PMIC wrapper of MT8135 to access MT6397 MFD. > > Signed-off-by: Flora Fu > Please explain what a PMIC wrapper is and why you need one for MT8135. I don't understand the purpose of this code at all. Is this just another way of accessing t

[PATCH v3 1/8] soc: mediatek: Add PMIC wrapper for MT8135 and MT6397 SoC

2014-12-04 Thread Flora Fu
Add PMIC wrapper of MT8135 to access MT6397 MFD. Signed-off-by: Flora Fu --- drivers/soc/Kconfig| 1 + drivers/soc/Makefile | 1 + drivers/soc/mediatek/Kconfig | 12 + drivers/soc/mediatek/Makefile | 1 + drivers/soc