Re: perf tools regression testing was Re: [PATCH v3 1/9] perf hists: Move hists_init() from util/evsel.c to util/hist.c

2012-09-25 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 25, 2012 at 10:47:48PM +0900, Namhyung Kim escreveu: > 2012-09-25 (화), 10:30 -0300, Arnaldo Carvalho de Melo: > > Em Tue, Sep 25, 2012 at 09:59:02PM +0900, Namhyung Kim escreveu: > > > Now I'm thinking of making it build-time test so that it can be executed > > > by make when specific

Re: perf tools regression testing was Re: [PATCH v3 1/9] perf hists: Move hists_init() from util/evsel.c to util/hist.c

2012-09-25 Thread Namhyung Kim
2012-09-25 (화), 10:30 -0300, Arnaldo Carvalho de Melo: > Em Tue, Sep 25, 2012 at 09:59:02PM +0900, Namhyung Kim escreveu: > > Now I'm thinking of making it build-time test so that it can be executed > > by make when specific argument is given - e.g. make C=1 ? > > I think there is room for a

perf tools regression testing was Re: [PATCH v3 1/9] perf hists: Move hists_init() from util/evsel.c to util/hist.c

2012-09-25 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 25, 2012 at 09:59:02PM +0900, Namhyung Kim escreveu: > 2012-09-25 (화), 08:05 -0300, Arnaldo Carvalho de Melo: > > Em Tue, Sep 25, 2012 at 10:25:13AM +0900, Namhyung Kim escreveu: > > > On Mon, 24 Sep 2012 13:02:39 -0300, Arnaldo Carvalho de Melo wrote: > > > > Em Mon, Sep 24, 2012 at

Re: [PATCH v3 1/9] perf hists: Move hists_init() from util/evsel.c to util/hist.c

2012-09-25 Thread Namhyung Kim
2012-09-25 (화), 08:05 -0300, Arnaldo Carvalho de Melo: > Em Tue, Sep 25, 2012 at 10:25:13AM +0900, Namhyung Kim escreveu: > > On Mon, 24 Sep 2012 13:02:39 -0300, Arnaldo Carvalho de Melo wrote: > > > Em Mon, Sep 24, 2012 at 11:24:03PM +0800, Feng Tang escreveu: > > >> Which looks more natural > >

Re: [PATCH v3 1/9] perf hists: Move hists_init() from util/evsel.c to util/hist.c

2012-09-25 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 25, 2012 at 10:25:13AM +0900, Namhyung Kim escreveu: > On Mon, 24 Sep 2012 13:02:39 -0300, Arnaldo Carvalho de Melo wrote: > > Em Mon, Sep 24, 2012 at 11:24:03PM +0800, Feng Tang escreveu: > >> Which looks more natural > > > > It is there to avoid dragging the hist code into the python

Re: [PATCH v3 1/9] perf hists: Move hists_init() from util/evsel.c to util/hist.c

2012-09-25 Thread Feng Tang
On Mon, 24 Sep 2012 13:02:39 -0300 Arnaldo Carvalho de Melo wrote: > Em Mon, Sep 24, 2012 at 11:24:03PM +0800, Feng Tang escreveu: > > Which looks more natural > > It is there to avoid dragging the hist code into the python binding :-\ Didn't notice this, please ignore this one. Thanks, Feng

Re: [PATCH v3 1/9] perf hists: Move hists_init() from util/evsel.c to util/hist.c

2012-09-25 Thread Feng Tang
On Mon, 24 Sep 2012 13:02:39 -0300 Arnaldo Carvalho de Melo a...@redhat.com wrote: Em Mon, Sep 24, 2012 at 11:24:03PM +0800, Feng Tang escreveu: Which looks more natural It is there to avoid dragging the hist code into the python binding :-\ Didn't notice this, please ignore this one.

Re: [PATCH v3 1/9] perf hists: Move hists_init() from util/evsel.c to util/hist.c

2012-09-25 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 25, 2012 at 10:25:13AM +0900, Namhyung Kim escreveu: On Mon, 24 Sep 2012 13:02:39 -0300, Arnaldo Carvalho de Melo wrote: Em Mon, Sep 24, 2012 at 11:24:03PM +0800, Feng Tang escreveu: Which looks more natural It is there to avoid dragging the hist code into the python binding

Re: [PATCH v3 1/9] perf hists: Move hists_init() from util/evsel.c to util/hist.c

2012-09-25 Thread Namhyung Kim
2012-09-25 (화), 08:05 -0300, Arnaldo Carvalho de Melo: Em Tue, Sep 25, 2012 at 10:25:13AM +0900, Namhyung Kim escreveu: On Mon, 24 Sep 2012 13:02:39 -0300, Arnaldo Carvalho de Melo wrote: Em Mon, Sep 24, 2012 at 11:24:03PM +0800, Feng Tang escreveu: Which looks more natural It is

perf tools regression testing was Re: [PATCH v3 1/9] perf hists: Move hists_init() from util/evsel.c to util/hist.c

2012-09-25 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 25, 2012 at 09:59:02PM +0900, Namhyung Kim escreveu: 2012-09-25 (화), 08:05 -0300, Arnaldo Carvalho de Melo: Em Tue, Sep 25, 2012 at 10:25:13AM +0900, Namhyung Kim escreveu: On Mon, 24 Sep 2012 13:02:39 -0300, Arnaldo Carvalho de Melo wrote: Em Mon, Sep 24, 2012 at 11:24:03PM

Re: perf tools regression testing was Re: [PATCH v3 1/9] perf hists: Move hists_init() from util/evsel.c to util/hist.c

2012-09-25 Thread Namhyung Kim
2012-09-25 (화), 10:30 -0300, Arnaldo Carvalho de Melo: Em Tue, Sep 25, 2012 at 09:59:02PM +0900, Namhyung Kim escreveu: Now I'm thinking of making it build-time test so that it can be executed by make when specific argument is given - e.g. make C=1 ? I think there is room for a 'make -C

Re: perf tools regression testing was Re: [PATCH v3 1/9] perf hists: Move hists_init() from util/evsel.c to util/hist.c

2012-09-25 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 25, 2012 at 10:47:48PM +0900, Namhyung Kim escreveu: 2012-09-25 (화), 10:30 -0300, Arnaldo Carvalho de Melo: Em Tue, Sep 25, 2012 at 09:59:02PM +0900, Namhyung Kim escreveu: Now I'm thinking of making it build-time test so that it can be executed by make when specific argument

Re: [PATCH v3 1/9] perf hists: Move hists_init() from util/evsel.c to util/hist.c

2012-09-24 Thread Namhyung Kim
On Mon, 24 Sep 2012 13:02:39 -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Sep 24, 2012 at 11:24:03PM +0800, Feng Tang escreveu: >> Which looks more natural > > It is there to avoid dragging the hist code into the python binding :-\ Hmm... it's so hairy. Can't we do better? Thanks, Namhyung

Re: [PATCH v3 1/9] perf hists: Move hists_init() from util/evsel.c to util/hist.c

2012-09-24 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 24, 2012 at 11:24:03PM +0800, Feng Tang escreveu: > Which looks more natural It is there to avoid dragging the hist code into the python binding :-\ - Arnaldo > Signed-off-by: Feng Tang > --- > tools/perf/util/evsel.c | 10 -- > tools/perf/util/evsel.h |2 -- >

[PATCH v3 1/9] perf hists: Move hists_init() from util/evsel.c to util/hist.c

2012-09-24 Thread Feng Tang
Which looks more natural Signed-off-by: Feng Tang --- tools/perf/util/evsel.c | 10 -- tools/perf/util/evsel.h |2 -- tools/perf/util/hist.c | 10 ++ tools/perf/util/hist.h |1 + 4 files changed, 11 insertions(+), 12 deletions(-) diff --git

[PATCH v3 1/9] perf hists: Move hists_init() from util/evsel.c to util/hist.c

2012-09-24 Thread Feng Tang
Which looks more natural Signed-off-by: Feng Tang feng.t...@intel.com --- tools/perf/util/evsel.c | 10 -- tools/perf/util/evsel.h |2 -- tools/perf/util/hist.c | 10 ++ tools/perf/util/hist.h |1 + 4 files changed, 11 insertions(+), 12 deletions(-) diff --git

Re: [PATCH v3 1/9] perf hists: Move hists_init() from util/evsel.c to util/hist.c

2012-09-24 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 24, 2012 at 11:24:03PM +0800, Feng Tang escreveu: Which looks more natural It is there to avoid dragging the hist code into the python binding :-\ - Arnaldo Signed-off-by: Feng Tang feng.t...@intel.com --- tools/perf/util/evsel.c | 10 -- tools/perf/util/evsel.h |

Re: [PATCH v3 1/9] perf hists: Move hists_init() from util/evsel.c to util/hist.c

2012-09-24 Thread Namhyung Kim
On Mon, 24 Sep 2012 13:02:39 -0300, Arnaldo Carvalho de Melo wrote: Em Mon, Sep 24, 2012 at 11:24:03PM +0800, Feng Tang escreveu: Which looks more natural It is there to avoid dragging the hist code into the python binding :-\ Hmm... it's so hairy. Can't we do better? Thanks, Namhyung -- To