Re: [PATCH v3 10/14] media: platform: pxa_camera: remove set_crop

2016-08-14 Thread Robert Jarzmik
Hans Verkuil writes: > On 08/08/2016 09:30 PM, Robert Jarzmik wrote: >> This is to be seen as a regression as the set_crop function is >> removed. This is a temporary situation in the v4l2 porting, and will >> have to be added later. > > This is a bit confusing, since in the next patch you say in

Re: [PATCH v3 10/14] media: platform: pxa_camera: remove set_crop

2016-08-14 Thread Hans Verkuil
On 08/08/2016 09:30 PM, Robert Jarzmik wrote: > This is to be seen as a regression as the set_crop function is > removed. This is a temporary situation in the v4l2 porting, and will > have to be added later. This is a bit confusing, since in the next patch you say in the commit log: - the s_crop

[PATCH v3 10/14] media: platform: pxa_camera: remove set_crop

2016-08-08 Thread Robert Jarzmik
This is to be seen as a regression as the set_crop function is removed. This is a temporary situation in the v4l2 porting, and will have to be added later. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 76 -- 1 file changed, 76 deletio