Re: [PATCH v3 10/15] phy: tegra: xusb: Add wake/sleepwalk for Tegra210

2020-10-14 Thread JC Kuo
On 9/28/20 9:40 PM, Thierry Reding wrote: > On Wed, Sep 09, 2020 at 04:10:36PM +0800, JC Kuo wrote: > [...] >> diff --git a/drivers/phy/tegra/xusb-tegra210.c >> b/drivers/phy/tegra/xusb-tegra210.c > [...] > > Could we add function pointers to struct tegra_xusb_lane_ops for all of > these? That wo

Re: [PATCH v3 10/15] phy: tegra: xusb: Add wake/sleepwalk for Tegra210

2020-09-28 Thread Thierry Reding
On Wed, Sep 09, 2020 at 04:10:36PM +0800, JC Kuo wrote: [...] > diff --git a/drivers/phy/tegra/xusb-tegra210.c > b/drivers/phy/tegra/xusb-tegra210.c [...] > @@ -2096,6 +2938,96 @@ static const struct phy_ops tegra210_sata_phy_ops = { > .owner = THIS_MODULE, > }; > > +static inline bool is

[PATCH v3 10/15] phy: tegra: xusb: Add wake/sleepwalk for Tegra210

2020-09-09 Thread JC Kuo
This commit implements Tegra210 XUSB PADCTL wake and sleepwalk routines. Sleepwalk logic is in PMC (always-on) hardware block. PMC driver provides managed access to the sleepwalk registers via regmap framework. Signed-off-by: JC Kuo --- v3: rename 'pmc_reg" with 'regmap' and move to the top of