Re: [PATCH v3 11/14] media: platform: pxa_camera: make a standalone v4l2 device

2016-08-14 Thread Robert Jarzmik
Hans Verkuil writes: > On 08/08/2016 09:30 PM, Robert Jarzmik wrote: > >> +pcdev->sensor = subdev; >> +pcdev->vdev.queue = &pcdev->vb2_vq; >> +pcdev->vdev.v4l2_dev = &pcdev->v4l2_dev; > > You're missing this line here: > > pcdev->vdev.ctrl_handler = subdev->ctrl_handler; > > Thi

Re: [PATCH v3 11/14] media: platform: pxa_camera: make a standalone v4l2 device

2016-08-14 Thread Hans Verkuil
On 08/08/2016 09:30 PM, Robert Jarzmik wrote: > +static int pxa_camera_sensor_bound(struct v4l2_async_notifier *notifier, > + struct v4l2_subdev *subdev, > + struct v4l2_async_subdev *asd) > +{ > + int err; > + struct v4l2_device *v4l2_dev = notifier->v4

[PATCH v3 11/14] media: platform: pxa_camera: make a standalone v4l2 device

2016-08-08 Thread Robert Jarzmik
This patch removes the soc_camera API dependency from pxa_camera. In the current status : - all previously captures are working the same on pxa270 - the s_crop() call was removed, judged not working (see what happens soc_camera_s_crop() when get_crop() == NULL) - if the pixel clock is provide