Re: [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators

2015-06-30 Thread Sudip Mukherjee
On Thu, Jun 25, 2015 at 10:53:33PM -0700, Juston Li wrote: > On Thu, Jun 25, 2015 at 9:05 PM, Sudip Mukherjee > wrote: > > Usually I use the checkpatch which is in linux-next. That will be the > > latest version. If you compare, last commit on checkpatch of staging > > tree was on April 16th, wher

Re: [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators

2015-06-25 Thread Juston Li
On Thu, Jun 25, 2015 at 9:05 PM, Sudip Mukherjee wrote: > Usually I use the checkpatch which is in linux-next. That will be the > latest version. If you compare, last commit on checkpatch of staging > tree was on April 16th, where as last commit in linux-next is on > June 19th. And if you use this

Re: [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators

2015-06-25 Thread Juston Li
On Thu, Jun 25, 2015 at 9:05 PM, Sudip Mukherjee wrote: > Usually I use the checkpatch which is in linux-next. That will be the > latest version. If you compare, last commit on checkpatch of staging > tree was on April 16th, where as last commit in linux-next is on > June 19th. And if you use this

Re: [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators

2015-06-25 Thread Sudip Mukherjee
On Thu, Jun 25, 2015 at 09:26:00AM -0700, Juston Li wrote: > On Thu, Jun 25, 2015 at 4:56 AM, Sudip Mukherjee > wrote: > > On Wed, Jun 24, 2015 at 09:25:12AM -0700, Juston Li wrote: > > > 2) Considering that you are giving consitent space around operators, then > > i think you have misse

Re: [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators

2015-06-25 Thread Juston Li
On Thu, Jun 25, 2015 at 4:56 AM, Sudip Mukherjee wrote: > On Wed, Jun 24, 2015 at 09:25:12AM -0700, Juston Li wrote: >> fixes checkpatch.pl error: >> ERROR: need consistent spacing around '' > little bit confused. > 1) Your subject says consistent space around operators but here it says >

Re: [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators

2015-06-25 Thread Sudip Mukherjee
On Wed, Jun 24, 2015 at 09:25:12AM -0700, Juston Li wrote: > fixes checkpatch.pl error: > ERROR: need consistent spacing around '' little bit confused. 1) Your subject says consistent space around operators but here it says around '' 2) Considering that you are giving consitent space around

[PATCH v3 11/19] staging: sm750fb: consistent spacing around operators

2015-06-24 Thread Juston Li
fixes checkpatch.pl error: ERROR: need consistent spacing around '' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c| 4 ++-- drivers/staging/sm750fb/ddk750_display.h | 4 ++-- drivers/staging/sm750fb/sm750.h | 2 +- drivers/staging/sm750fb/sm750_hw.c | 4 ++-