Re: [PATCH v3 12/13] mmc: mmci: add explicit clk control

2014-05-28 Thread Ulf Hansson
On 28 May 2014 10:28, Srinivas Kandagatla wrote: > > > On 28/05/14 09:02, Linus Walleij wrote: >> >> On Tue, May 27, 2014 at 12:39 AM, Srinivas Kandagatla >> wrote: >>> >>> On 26/05/14 15:21, Ulf Hansson wrote: On 23 May 2014 14:52, wrote: >> >> > > + bool

Re: [PATCH v3 12/13] mmc: mmci: add explicit clk control

2014-05-28 Thread Srinivas Kandagatla
On 28/05/14 09:02, Linus Walleij wrote: On Tue, May 27, 2014 at 12:39 AM, Srinivas Kandagatla wrote: On 26/05/14 15:21, Ulf Hansson wrote: On 23 May 2014 14:52, wrote: + boolexplicit_mclk_control; + boolcclk_is_mclk; I can't see why

Re: [PATCH v3 12/13] mmc: mmci: add explicit clk control

2014-05-28 Thread Linus Walleij
On Tue, May 27, 2014 at 12:39 AM, Srinivas Kandagatla wrote: > On 26/05/14 15:21, Ulf Hansson wrote: >> On 23 May 2014 14:52, wrote: >>> >>> + boolexplicit_mclk_control; >>> + boolcclk_is_mclk; >> >> I can't see why you need to have both these

Re: [PATCH v3 12/13] mmc: mmci: add explicit clk control

2014-05-27 Thread Srinivas Kandagatla
On 27/05/14 15:07, Ulf Hansson wrote: Hmm. Looking a bit deeper into this, we have some additional related code to fixup. :-) In ->probe(), we do clk_set_rate(100MHz), if the mclk > 100MHz. That's due to the current variants don't support higher frequency than this. It seems like the Qcom vari

Re: [PATCH v3 12/13] mmc: mmci: add explicit clk control

2014-05-27 Thread Ulf Hansson
>> Hmm. Looking a bit deeper into this, we have some additional related >> code to fixup. :-) >> >> In ->probe(), we do clk_set_rate(100MHz), if the mclk > 100MHz. That's >> due to the current variants don't support higher frequency than this. >> It seems like the Qcom variant may support up to 208

Re: [PATCH v3 12/13] mmc: mmci: add explicit clk control

2014-05-27 Thread Srinivas Kandagatla
On 27/05/14 10:32, Ulf Hansson wrote: On 27 May 2014 00:39, Srinivas Kandagatla wrote: Hi Ulf, Thankyou for the comments. On 26/05/14 15:21, Ulf Hansson wrote: On 23 May 2014 14:52, wrote: From: Srinivas Kandagatla On Controllers like Qcom SD card controller where cclk is mclk and m

Re: [PATCH v3 12/13] mmc: mmci: add explicit clk control

2014-05-27 Thread Ulf Hansson
On 27 May 2014 00:39, Srinivas Kandagatla wrote: > Hi Ulf, > Thankyou for the comments. > > > On 26/05/14 15:21, Ulf Hansson wrote: >> >> On 23 May 2014 14:52, wrote: >>> >>> From: Srinivas Kandagatla >>> >>> On Controllers like Qcom SD card controller where cclk is mclk and mclk >>> should >>>

Re: [PATCH v3 12/13] mmc: mmci: add explicit clk control

2014-05-26 Thread Srinivas Kandagatla
Hi Ulf, Thankyou for the comments. On 26/05/14 15:21, Ulf Hansson wrote: On 23 May 2014 14:52, wrote: From: Srinivas Kandagatla On Controllers like Qcom SD card controller where cclk is mclk and mclk should be directly controlled by the driver. This patch adds support to control mclk direc

Re: [PATCH v3 12/13] mmc: mmci: add explicit clk control

2014-05-26 Thread Ulf Hansson
On 26 May 2014 16:21, Ulf Hansson wrote: > On 23 May 2014 14:52, wrote: >> From: Srinivas Kandagatla >> >> On Controllers like Qcom SD card controller where cclk is mclk and mclk >> should >> be directly controlled by the driver. >> >> This patch adds support to control mclk directly in the dr

Re: [PATCH v3 12/13] mmc: mmci: add explicit clk control

2014-05-26 Thread Ulf Hansson
On 23 May 2014 14:52, wrote: > From: Srinivas Kandagatla > > On Controllers like Qcom SD card controller where cclk is mclk and mclk should > be directly controlled by the driver. > > This patch adds support to control mclk directly in the driver, and also > adds explicit_mclk_control and cclk_i

[PATCH v3 12/13] mmc: mmci: add explicit clk control

2014-05-23 Thread srinivas . kandagatla
From: Srinivas Kandagatla On Controllers like Qcom SD card controller where cclk is mclk and mclk should be directly controlled by the driver. This patch adds support to control mclk directly in the driver, and also adds explicit_mclk_control and cclk_is_mclk flags in variant structure giving mo