Re: [PATCH v3 13/13] platform/x86: intel_cht_int33fe: Replacing the old connections with references

2019-05-08 Thread Heikki Krogerus
On Wed, Apr 17, 2019 at 11:14:19PM +0200, Hans de Goede wrote: > Hi, > > On 17-04-19 11:19, Hans de Goede wrote: > > Note that another problem with this series which I noticed while testing > > is that the usb-role-switch is not being found at all anymore after > > this ("Replacing the old connect

Re: [PATCH v3 13/13] platform/x86: intel_cht_int33fe: Replacing the old connections with references

2019-05-08 Thread Heikki Krogerus
On Wed, Apr 17, 2019 at 06:03:03PM +0200, Hans de Goede wrote: > Hi, > > On 17-04-19 12:44, Heikki Krogerus wrote: > > On Wed, Apr 17, 2019 at 12:15:18PM +0200, Hans de Goede wrote: > > > Hi, > > > > > > On 17-04-19 11:32, Heikki Krogerus wrote: > > > > On Wed, Apr 17, 2019 at 11:19:28AM +0200, H

Re: [PATCH v3 13/13] platform/x86: intel_cht_int33fe: Replacing the old connections with references

2019-04-17 Thread Hans de Goede
Hi, On 17-04-19 11:19, Hans de Goede wrote: Note that another problem with this series which I noticed while testing is that the usb-role-switch is not being found at all anymore after this ("Replacing the old connections with references") patch. I still need start debugging that. Ok, I've jus

Re: [PATCH v3 13/13] platform/x86: intel_cht_int33fe: Replacing the old connections with references

2019-04-17 Thread Hans de Goede
Hi, On 17-04-19 12:44, Heikki Krogerus wrote: On Wed, Apr 17, 2019 at 12:15:18PM +0200, Hans de Goede wrote: Hi, On 17-04-19 11:32, Heikki Krogerus wrote: On Wed, Apr 17, 2019 at 11:19:28AM +0200, Hans de Goede wrote: That is not going to work since the (virtual) mux / orientation-switch

Re: [PATCH v3 13/13] platform/x86: intel_cht_int33fe: Replacing the old connections with references

2019-04-17 Thread Hans de Goede
Hi, On 17-04-19 13:04, Heikki Krogerus wrote: On Wed, Apr 17, 2019 at 11:52:15AM +0200, Hans de Goede wrote: Hi, On 17-04-19 11:32, Heikki Krogerus wrote: On Wed, Apr 17, 2019 at 11:19:28AM +0200, Hans de Goede wrote: Hi, On 17-04-19 08:39, Heikki Krogerus wrote: On Tue, Apr 16, 2019 at 11

Re: [PATCH v3 13/13] platform/x86: intel_cht_int33fe: Replacing the old connections with references

2019-04-17 Thread Heikki Krogerus
On Wed, Apr 17, 2019 at 11:52:15AM +0200, Hans de Goede wrote: > Hi, > > On 17-04-19 11:32, Heikki Krogerus wrote: > > On Wed, Apr 17, 2019 at 11:19:28AM +0200, Hans de Goede wrote: > > > Hi, > > > > > > On 17-04-19 08:39, Heikki Krogerus wrote: > > > > On Tue, Apr 16, 2019 at 11:35:36PM +0200, H

Re: [PATCH v3 13/13] platform/x86: intel_cht_int33fe: Replacing the old connections with references

2019-04-17 Thread Heikki Krogerus
On Wed, Apr 17, 2019 at 12:15:18PM +0200, Hans de Goede wrote: > Hi, > > On 17-04-19 11:32, Heikki Krogerus wrote: > > On Wed, Apr 17, 2019 at 11:19:28AM +0200, Hans de Goede wrote: > > > > > > That is not going to work since the (virtual) mux / orientation-switch > > > devices are only registe

Re: [PATCH v3 13/13] platform/x86: intel_cht_int33fe: Replacing the old connections with references

2019-04-17 Thread Hans de Goede
Hi, On 17-04-19 11:32, Heikki Krogerus wrote: On Wed, Apr 17, 2019 at 11:19:28AM +0200, Hans de Goede wrote: That is not going to work since the (virtual) mux / orientation-switch devices are only registered once the driver binds to the piusb30532 i2c device, so when creating the nodes we o

Re: [PATCH v3 13/13] platform/x86: intel_cht_int33fe: Replacing the old connections with references

2019-04-17 Thread Hans de Goede
Hi, On 17-04-19 11:32, Heikki Krogerus wrote: On Wed, Apr 17, 2019 at 11:19:28AM +0200, Hans de Goede wrote: Hi, On 17-04-19 08:39, Heikki Krogerus wrote: On Tue, Apr 16, 2019 at 11:35:36PM +0200, Hans de Goede wrote: Hi, On 12-04-19 15:41, Heikki Krogerus wrote: Now that the software node

Re: [PATCH v3 13/13] platform/x86: intel_cht_int33fe: Replacing the old connections with references

2019-04-17 Thread Heikki Krogerus
On Wed, Apr 17, 2019 at 11:19:28AM +0200, Hans de Goede wrote: > Hi, > > On 17-04-19 08:39, Heikki Krogerus wrote: > > On Tue, Apr 16, 2019 at 11:35:36PM +0200, Hans de Goede wrote: > > > Hi, > > > > > > On 12-04-19 15:41, Heikki Krogerus wrote: > > > > Now that the software nodes support referen

Re: [PATCH v3 13/13] platform/x86: intel_cht_int33fe: Replacing the old connections with references

2019-04-17 Thread Hans de Goede
Hi, On 17-04-19 08:39, Heikki Krogerus wrote: On Tue, Apr 16, 2019 at 11:35:36PM +0200, Hans de Goede wrote: Hi, On 12-04-19 15:41, Heikki Krogerus wrote: Now that the software nodes support references, and the device connection API support parsing fwnode references, replacing the old connect

Re: [PATCH v3 13/13] platform/x86: intel_cht_int33fe: Replacing the old connections with references

2019-04-16 Thread Heikki Krogerus
On Tue, Apr 16, 2019 at 11:35:36PM +0200, Hans de Goede wrote: > Hi, > > On 12-04-19 15:41, Heikki Krogerus wrote: > > Now that the software nodes support references, and the > > device connection API support parsing fwnode references, > > replacing the old connection descriptions with software no

Re: [PATCH v3 13/13] platform/x86: intel_cht_int33fe: Replacing the old connections with references

2019-04-16 Thread Hans de Goede
Hi, On 12-04-19 15:41, Heikki Krogerus wrote: Now that the software nodes support references, and the device connection API support parsing fwnode references, replacing the old connection descriptions with software node references. Relying on device names when matching the connection would not h

[PATCH v3 13/13] platform/x86: intel_cht_int33fe: Replacing the old connections with references

2019-04-12 Thread Heikki Krogerus
Now that the software nodes support references, and the device connection API support parsing fwnode references, replacing the old connection descriptions with software node references. Relying on device names when matching the connection would not have been possible to link the USB Type-C connecto